From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2] sound: dmasound_atari: Mark expected switch fall-through
Date: Mon, 29 Jul 2019 14:48:31 -0700 [thread overview]
Message-ID: <201907291448.E375AA59F@keescook> (raw)
In-Reply-To: <20190729205454.GA5084@embeddedor>
On Mon, Jul 29, 2019 at 03:54:54PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: m68k):
>
> sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]: => 1449:24
>
> Notice that, in this particular case, the code comment is
> modified in accordance with what GCC is expecting to find.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> Changes in v2:
> - Update code so switch and case statements are at the same indent.
>
> sound/oss/dmasound/dmasound_atari.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/sound/oss/dmasound/dmasound_atari.c b/sound/oss/dmasound/dmasound_atari.c
> index 83653683fd68..823ccfa089b2 100644
> --- a/sound/oss/dmasound/dmasound_atari.c
> +++ b/sound/oss/dmasound/dmasound_atari.c
> @@ -1432,25 +1432,25 @@ static int FalconMixerIoctl(u_int cmd, u_long arg)
> {
> int data;
> switch (cmd) {
> - case SOUND_MIXER_READ_RECMASK:
> + case SOUND_MIXER_READ_RECMASK:
> return IOCTL_OUT(arg, SOUND_MASK_MIC);
> - case SOUND_MIXER_READ_DEVMASK:
> + case SOUND_MIXER_READ_DEVMASK:
> return IOCTL_OUT(arg, SOUND_MASK_VOLUME | SOUND_MASK_MIC | SOUND_MASK_SPEAKER);
> - case SOUND_MIXER_READ_STEREODEVS:
> + case SOUND_MIXER_READ_STEREODEVS:
> return IOCTL_OUT(arg, SOUND_MASK_VOLUME | SOUND_MASK_MIC);
> - case SOUND_MIXER_READ_VOLUME:
> + case SOUND_MIXER_READ_VOLUME:
> return IOCTL_OUT(arg,
> VOLUME_ATT_TO_VOXWARE(dmasound.volume_left) |
> VOLUME_ATT_TO_VOXWARE(dmasound.volume_right) << 8);
> - case SOUND_MIXER_READ_CAPS:
> + case SOUND_MIXER_READ_CAPS:
> return IOCTL_OUT(arg, SOUND_CAP_EXCL_INPUT);
> - case SOUND_MIXER_WRITE_MIC:
> + case SOUND_MIXER_WRITE_MIC:
> IOCTL_IN(arg, data);
> tt_dmasnd.input_gain =
> RECLEVEL_VOXWARE_TO_GAIN(data & 0xff) << 4 |
> RECLEVEL_VOXWARE_TO_GAIN(data >> 8 & 0xff);
> - /* fall thru, return set value */
> - case SOUND_MIXER_READ_MIC:
> + /* fall through - return set value */
> + case SOUND_MIXER_READ_MIC:
> return IOCTL_OUT(arg,
> RECLEVEL_GAIN_TO_VOXWARE(tt_dmasnd.input_gain >> 4 & 0xf) |
> RECLEVEL_GAIN_TO_VOXWARE(tt_dmasnd.input_gain & 0xf) << 8);
> --
> 2.22.0
>
--
Kees Cook
next prev parent reply other threads:[~2019-07-29 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 20:54 [PATCH v2] sound: dmasound_atari: Mark expected switch fall-through Gustavo A. R. Silva
2019-07-29 21:48 ` Kees Cook [this message]
2019-07-30 7:05 ` Geert Uytterhoeven
2019-07-30 7:36 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907291448.E375AA59F@keescook \
--to=keescook@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=geert@linux-m68k.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).