From: Abel Vesa <abel.vesa@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Guido Gunther <agx@sigxcpu.org>,
Anson Huang <anson.huang@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-clk <linux-clk@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] clk: imx8mq: Mark AHB clock as critical
Date: Mon, 29 Jul 2019 18:07:12 +0300 [thread overview]
Message-ID: <20190729150712.3ah2ayeonhdfrt5n@fsr-ub1664-175> (raw)
In-Reply-To: <CAOMZO5C0WbaDzFcjeXeS1PivWUme=bzPur6Hj_xNz1oVzvpW2Q@mail.gmail.com>
Hi Fabio,
On 19-07-29 09:19:01, Fabio Estevam wrote:
> Hi Abel,
>
> On Mon, Jul 29, 2019 at 4:23 AM Abel Vesa <abel.vesa@nxp.com> wrote:
> >
> > Keep the AHB clock always on since there is no driver to control it and
> > all the other clocks that use it as parent rely on it being always enabled.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > Tested-by: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> >
> > Changes since v1:
> > * added comment in code why this clock is critical
> > * added T-b by Daniel
> >
> > This needs to go in ASAP to fix the boot hang.
>
> Which boot hang exactly? Are you referring to the TMU clock hang?
>
> On the TMU clock hang, the issue was that the qoriq_thermal needs to
> enable the TMU clock.
>
> Please always provide a detailed description in the commit log.
>
> Also, if this fixes a hang it should contain a Fixes tag.
Please have a the explanation here:
https://lkml.org/lkml/2019/7/28/306
next prev parent reply other threads:[~2019-07-29 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 7:23 [PATCH v2] clk: imx8mq: Mark AHB clock as critical Abel Vesa
2019-07-29 12:19 ` Fabio Estevam
2019-07-29 15:07 ` Abel Vesa [this message]
2019-07-29 15:40 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729150712.3ah2ayeonhdfrt5n@fsr-ub1664-175 \
--to=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).