From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E138C433FF for ; Mon, 29 Jul 2019 19:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6156121655 for ; Mon, 29 Jul 2019 19:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428236; bh=obB4wLO2yhIWMyZPlhiEwLiR3oIFHKt+hOnNiPSzV2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tXCRJTj52Anyj2li3+YGpIYRaCTuhdbmFjAKv3Y/jA8qklLGUM5xbK3SoA2N+IBh8 8sHsRZuuChh7iYtPWn3dAjCl+J3A7Hj33EiianQy/cwzEl3uRoSz8B6swpK6luk8Bc NmdUFuB/gMAvGsZ9q8RqKtg/RmBE1uyUFEsaG8jA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729405AbfG2TXz (ORCPT ); Mon, 29 Jul 2019 15:23:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:36016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbfG2TXw (ORCPT ); Mon, 29 Jul 2019 15:23:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BBD372070B; Mon, 29 Jul 2019 19:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428231; bh=obB4wLO2yhIWMyZPlhiEwLiR3oIFHKt+hOnNiPSzV2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WWHw9bKOJ63LVlMmqhLHzWMo5K+Fck/CSUxWL3WbS2+PP8GZ+QEeH1DNQ99UtYHSZ CSoIdSyL7cnx1jyCxJ597o6xbUFYvGw6QGmBBsBv7JAab4wSM0o4ctaSFebvJKSoBf p78lFpiBVl/a8FV2MpbgXOp6GrQs9AiUYvKnuIpg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+d454a826e670502484b8@syzkaller.appspotmail.com, Jeremy Sowden , Sven Eckelmann , Simon Wunderlich , Sasha Levin Subject: [PATCH 4.14 011/293] batman-adv: fix for leaked TVLV handler. Date: Mon, 29 Jul 2019 21:18:22 +0200 Message-Id: <20190729190821.206535000@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 17f78dd1bd624a4dd78ed5db3284a63ee807fcc3 ] A handler for BATADV_TVLV_ROAM was being registered when the translation-table was initialized, but not unregistered when the translation-table was freed. Unregister it. Fixes: 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to use tvlv unicast packets") Reported-by: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com Signed-off-by: Jeremy Sowden Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich Signed-off-by: Sasha Levin --- net/batman-adv/translation-table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 020a8adc4cce..2c2670b85fa9 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -3750,6 +3750,8 @@ static void batadv_tt_purge(struct work_struct *work) void batadv_tt_free(struct batadv_priv *bat_priv) { + batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_ROAM, 1); + batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_TT, 1); batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_TT, 1); -- 2.20.1