From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F4CC433FF for ; Mon, 29 Jul 2019 19:58:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A93292054F for ; Mon, 29 Jul 2019 19:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564430288; bh=wjda5QJsyKPRuwfdHw8PBFYDu6Y7z8KRQaNDPrG6g20=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=A7186RXKfFyNokg4lpsFbqsP2gaGdeH7tm7HXDMFzjjQsysbydzY7xLb5PvfHHqo+ YoxlByumEoEpdkfziAwaKqNBjMIizc46wQozg9BJDWT7M0HdvWCVxsiUzHnb12L8lq ABQa1b6VqnwLc+mbwKwAJnocQE6OV9IUz+SLbdec= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391113AbfG2T6H (ORCPT ); Mon, 29 Jul 2019 15:58:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:50440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403935AbfG2T6E (ORCPT ); Mon, 29 Jul 2019 15:58:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C3062054F; Mon, 29 Jul 2019 19:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564430283; bh=wjda5QJsyKPRuwfdHw8PBFYDu6Y7z8KRQaNDPrG6g20=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YRmq1TF3qRi/SW2TYpVUyWhYt0SY+NqPtuxyc4wy5bEeEkUH/cuJeAhiF29pGwb3d 6+1nls2yBAvC1tK7giQWyH5NGlwo0DDh40KGIc6oVtYHvcS75YonBBNGVetGz5JdnR YLIPbd7coSFaKXJiVdLG9FqsN6sGnqhtrKfd2m2Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu , "Lad, Prabhakar" , Mukesh Ojha , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 016/293] media: vpss: fix a potential NULL pointer dereference Date: Mon, 29 Jul 2019 21:18:27 +0200 Message-Id: <20190729190821.735961797@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit e08f0761234def47961d3252eac09ccedfe4c6a0 ] In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Acked-by: Lad, Prabhakar Reviewed-by: Mukesh Ojha Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/davinci/vpss.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c index f2d27b932999..2ee4cd9e6d80 100644 --- a/drivers/media/platform/davinci/vpss.c +++ b/drivers/media/platform/davinci/vpss.c @@ -518,6 +518,11 @@ static int __init vpss_init(void) return -EBUSY; oper_cfg.vpss_regs_base2 = ioremap(VPSS_CLK_CTRL, 4); + if (unlikely(!oper_cfg.vpss_regs_base2)) { + release_mem_region(VPSS_CLK_CTRL, 4); + return -ENOMEM; + } + writel(VPSS_CLK_CTRL_VENCCLKEN | VPSS_CLK_CTRL_DACCLKEN, oper_cfg.vpss_regs_base2); -- 2.20.1