From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88865C41514 for ; Mon, 29 Jul 2019 19:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53C9C216C8 for ; Mon, 29 Jul 2019 19:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428395; bh=8d90N1f6X6r12t1S7fD+JCOclmrbvumpbXPSk48yZ04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rewlxvuZflZHhFeSI/5AgFmtmVuJgMPRkvgLJFxaKH5d0QfL6P/cX9Kk24GnkL787 BN9+2OMVtOGbCnoMW8XHJK58eY5nQ5Ewg05JZjU2RBjHx1BxD7mBbcDuxIRIbZ0oYJ WknIhbWQSsOfmcNCvQrLfkwUyyul68b83/hROcGY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728086AbfG2T0e (ORCPT ); Mon, 29 Jul 2019 15:26:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:38940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729762AbfG2T0b (ORCPT ); Mon, 29 Jul 2019 15:26:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8202217D6; Mon, 29 Jul 2019 19:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428390; bh=8d90N1f6X6r12t1S7fD+JCOclmrbvumpbXPSk48yZ04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NDZu2ReAq47GXKFi9C916JP6naKWrNp5Dj1VeZ/n71ryYqAsAHnAy8KkE1xYoHX3Y liY6uTX05lqax2EjdGrtNVEG4oprw7G+PgTP0hd6Hq1xAZRpz1OREiZbHhtClZYFE4 YVTIgPFuUhrjo5XfLd89K9XH79jzB8m9AqIMG8OY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+4f0529365f7f2208d9f0@syzkaller.appspotmail.com, Jeremy Sowden , Steffen Klassert , Sasha Levin Subject: [PATCH 4.14 022/293] af_key: fix leaks in key_pol_get_resp and dump_sp. Date: Mon, 29 Jul 2019 21:18:33 +0200 Message-Id: <20190729190822.702269515@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 7c80eb1c7e2b8420477fbc998971d62a648035d9 ] In both functions, if pfkey_xfrm_policy2msg failed we leaked the newly allocated sk_buff. Free it on error. Fixes: 55569ce256ce ("Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.") Reported-by: syzbot+4f0529365f7f2208d9f0@syzkaller.appspotmail.com Signed-off-by: Jeremy Sowden Signed-off-by: Steffen Klassert Signed-off-by: Sasha Levin --- net/key/af_key.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/key/af_key.c b/net/key/af_key.c index b095551a5773..ac38b47e9f86 100644 --- a/net/key/af_key.c +++ b/net/key/af_key.c @@ -2438,8 +2438,10 @@ static int key_pol_get_resp(struct sock *sk, struct xfrm_policy *xp, const struc goto out; } err = pfkey_xfrm_policy2msg(out_skb, xp, dir); - if (err < 0) + if (err < 0) { + kfree_skb(out_skb); goto out; + } out_hdr = (struct sadb_msg *) out_skb->data; out_hdr->sadb_msg_version = hdr->sadb_msg_version; @@ -2690,8 +2692,10 @@ static int dump_sp(struct xfrm_policy *xp, int dir, int count, void *ptr) return PTR_ERR(out_skb); err = pfkey_xfrm_policy2msg(out_skb, xp, dir); - if (err < 0) + if (err < 0) { + kfree_skb(out_skb); return err; + } out_hdr = (struct sadb_msg *) out_skb->data; out_hdr->sadb_msg_version = pfk->dump.msg_version; -- 2.20.1