From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6D7C433FF for ; Mon, 29 Jul 2019 19:25:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C033921655 for ; Mon, 29 Jul 2019 19:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428323; bh=r0jPVWdP2h3eaXNjoHKlq5SroAKe5morQsPOLgWPTyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Xj0e2drYYYqIrtpYxd6ECgaLg9iubqhMArgmG7lXZMz2KBjpv4ebdREyBHW4JzIvu PBeGQVaHiwj06U0DTxdYVQ16AleodKBVTLAGxeSviYgDliU244JwdSOS5oPaFRJcml 7HJPTurrKpoH+vgOCT7tc0OnMk5AMJhM77EUV/r4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388287AbfG2TZW (ORCPT ); Mon, 29 Jul 2019 15:25:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:37576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387496AbfG2TZR (ORCPT ); Mon, 29 Jul 2019 15:25:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 554A920C01; Mon, 29 Jul 2019 19:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428316; bh=r0jPVWdP2h3eaXNjoHKlq5SroAKe5morQsPOLgWPTyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ltB3OEGUf+ugLUa/bTTGKWvJBjRBj+JFt4iB17rDpZHIJU8GkVfP67OL2nGWjyvdx OyRSs8ltwKfBIPf0JNL20YNI8k9ME56sqKqeuETdA0+/l8TR7Hhh1d3/Xwi6R1m6Q8 /NclKg36Sy4MbayjiKqn4eX6hP9lDMdPx5tZbtqg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Wiedmann , Heiko Carstens , Sasha Levin Subject: [PATCH 4.14 037/293] s390/qdio: handle PENDING state for QEBSM devices Date: Mon, 29 Jul 2019 21:18:48 +0200 Message-Id: <20190729190825.142115457@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 04310324c6f482921c071444833e70fe861b73d9 ] When a CQ-enabled device uses QEBSM for SBAL state inspection, get_buf_states() can return the PENDING state for an Output Queue. get_outbound_buffer_frontier() isn't prepared for this, and any PENDING buffer will permanently stall all further completion processing on this Queue. This isn't a concern for non-QEBSM devices, as get_buf_states() for such devices will manually turn PENDING buffers into EMPTY ones. Fixes: 104ea556ee7f ("qdio: support asynchronous delivery of storage blocks") Signed-off-by: Julian Wiedmann Signed-off-by: Heiko Carstens Signed-off-by: Sasha Levin --- drivers/s390/cio/qdio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c index c7afdbded26b..ab8dd81fbc2b 100644 --- a/drivers/s390/cio/qdio_main.c +++ b/drivers/s390/cio/qdio_main.c @@ -759,6 +759,7 @@ static int get_outbound_buffer_frontier(struct qdio_q *q) switch (state) { case SLSB_P_OUTPUT_EMPTY: + case SLSB_P_OUTPUT_PENDING: /* the adapter got it */ DBF_DEV_EVENT(DBF_INFO, q->irq_ptr, "out empty:%1d %02x", q->nr, count); -- 2.20.1