From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D32C433FF for ; Mon, 29 Jul 2019 19:29:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2ABC2217D4 for ; Mon, 29 Jul 2019 19:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428571; bh=aW/DoCHxhgIWen+f8hrgEFLzKXjHLURQXKYaosEwwJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2ca0cKSl3pqIwkmtOoqi5G5boaWScZVUy/lUp60K0wlKNIMGHL8CejUwA8vGkwXi6 pStWC36cFVGwr/lMG01vvMJYm3zHkhiCgK2Wy7Y+2qfsU3n+OVUqTKZH/jhkEyXqDj WLedtBM0Kqua6OL4ZriwYwWTKuNNaUNbf73uXJrA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387655AbfG2T33 (ORCPT ); Mon, 29 Jul 2019 15:29:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:42074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728345AbfG2T3W (ORCPT ); Mon, 29 Jul 2019 15:29:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B8B52070B; Mon, 29 Jul 2019 19:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428561; bh=aW/DoCHxhgIWen+f8hrgEFLzKXjHLURQXKYaosEwwJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AwvmJDkHLYuPHD1zfvNqxdNj4PCncHsvdava+XsaaRJUM7Npf3X2lfE0IsIDiYAwS 4JLYAq3BrRvuXvrusnv1DFz1e0eftlYRBVF6BcDQJxpp1a58zlW9wLq1heqz6HyZB7 fBY+CG/5FLv+m5WbkHgkUFm4UsJNDf3rmUixB4cI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shivasharan S , "Martin K. Petersen" Subject: [PATCH 4.14 116/293] scsi: megaraid_sas: Fix calculation of target ID Date: Mon, 29 Jul 2019 21:20:07 +0200 Message-Id: <20190729190833.487686220@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shivasharan S commit c8f96df5b8e633056b7ebf5d52a9d6fb1b156ce3 upstream. In megasas_get_target_prop(), driver is incorrectly calculating the target ID for devices with channel 1 and 3. Due to this, firmware will either fail the command (if there is no device with the target id sent from driver) or could return the properties for a target which was not intended. Devices could end up with the wrong queue depth due to this. Fix target id calculation for channel 1 and 3. Fixes: 96188a89cc6d ("scsi: megaraid_sas: NVME interface target prop added") Cc: stable@vger.kernel.org Signed-off-by: Shivasharan S Signed-off-by: Martin K. Petersen Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -5806,7 +5806,8 @@ megasas_get_target_prop(struct megasas_i int ret; struct megasas_cmd *cmd; struct megasas_dcmd_frame *dcmd; - u16 targetId = (sdev->channel % 2) + sdev->id; + u16 targetId = ((sdev->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + + sdev->id; cmd = megasas_get_cmd(instance);