From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D84C76186 for ; Mon, 29 Jul 2019 19:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFF4B2070B for ; Mon, 29 Jul 2019 19:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428618; bh=vCaANHqlQGM+SF6//lFviA11GynhjsEXs08O1x93BN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=A7mPrPuB5hOlDFRWZS8/ft4+xeHiQb2HTGgCN8vZjtBBUXjtI2EfQt5kLmrafUrZH koRUlbikbm5bEInpNLIhj70jpJiXyCzRWsKyIxqTtJQ6gnLq4L/xty8KftfsONwHaF yiYqM7ixvT+stq5BJsSXOApJTCjj9tNPg2MvDxyY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388402AbfG2TaQ (ORCPT ); Mon, 29 Jul 2019 15:30:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:42966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388173AbfG2TaN (ORCPT ); Mon, 29 Jul 2019 15:30:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 658DC2070B; Mon, 29 Jul 2019 19:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428612; bh=vCaANHqlQGM+SF6//lFviA11GynhjsEXs08O1x93BN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hHfHcCdzmw4ejoBjw+gjrCAADWvoSJB+maA1tA1OcbHzMDFtRIkeKeptYtxBjnfkD BgVjmSayOJlf+3SucZKzJH15Eep+BD8Vs0bNi9CYj+EMU9QPvjMMv0a/aYHbD8/4HN agBKfdx+wI8+QFZMGBqWLsjDgl0lnda0TvTPgtzQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hui Wang , Dmitry Torokhov Subject: [PATCH 4.14 130/293] Input: alps - fix a mismatch between a condition check and its comment Date: Mon, 29 Jul 2019 21:20:21 +0200 Message-Id: <20190729190834.542731525@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hui Wang commit 771a081e44a9baa1991ef011cc453ef425591740 upstream. In the function alps_is_cs19_trackpoint(), we check if the param[1] is in the 0x20~0x2f range, but the code we wrote for this checking is not correct: (param[1] & 0x20) does not mean param[1] is in the range of 0x20~0x2f, it also means the param[1] is in the range of 0x30~0x3f, 0x60~0x6f... Now fix it with a new condition checking ((param[1] & 0xf0) == 0x20). Fixes: 7e4935ccc323 ("Input: alps - don't handle ALPS cs19 trackpoint-only device") Cc: stable@vger.kernel.org Signed-off-by: Hui Wang Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/mouse/alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c @@ -2875,7 +2875,7 @@ static bool alps_is_cs19_trackpoint(stru * trackpoint-only devices have their variant_ids equal * TP_VARIANT_ALPS and their firmware_ids are in 0x20~0x2f range. */ - return param[0] == TP_VARIANT_ALPS && (param[1] & 0x20); + return param[0] == TP_VARIANT_ALPS && ((param[1] & 0xf0) == 0x20); } static int alps_identify(struct psmouse *psmouse, struct alps_data *priv)