From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34ECFC433FF for ; Mon, 29 Jul 2019 19:33:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0234E2171F for ; Mon, 29 Jul 2019 19:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428811; bh=aHqgQJKP03ZM+yob4oeTuv5fUdGLTHzvHiuLjfYAErc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rIAH8Ruow0mm+kD/pVWWKrIIViT6RJbFVgz/FQnt3gV5GnixoNkSpTyRkxvD0IMR9 iiZOh5WVZhMoN05G9VVwCUyFEGZi3fWDwqiSidss1H7SfHTt8Mgpzaf5EN2x08naC/ bNEe1jccynVgwr9wn0Du+2crcMZ+/XdUAvHRPdWw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729916AbfG2Td3 (ORCPT ); Mon, 29 Jul 2019 15:33:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:47528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730342AbfG2TdY (ORCPT ); Mon, 29 Jul 2019 15:33:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B787217D4; Mon, 29 Jul 2019 19:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428803; bh=aHqgQJKP03ZM+yob4oeTuv5fUdGLTHzvHiuLjfYAErc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kbG8wIchETwt1spsQ3w3MjkZ36ZB8KsozrOE1urUD5/7sGKBX2cXXmPJin+P1xVLt S1gCk1AluWYECVoMhTE1gcGWqLObP0RCFA8S1Z14t1LSOpovnABBU5FZodoUpp5bVM +wzFD/xugVe1r6+SpYE8d++O3tRrsyr4Y8uKpRMQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Zabel , Ezequiel Garcia , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.14 142/293] media: coda: Remove unbalanced and unneeded mutex unlock Date: Mon, 29 Jul 2019 21:20:33 +0200 Message-Id: <20190729190835.422548498@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ezequiel Garcia commit 766b9b168f6c75c350dd87c3e0bc6a9b322f0013 upstream. The mutex unlock in the threaded interrupt handler is not paired with any mutex lock. Remove it. This bug has been here for a really long time, so it applies to any stable repo. Reviewed-by: Philipp Zabel Signed-off-by: Ezequiel Garcia Signed-off-by: Hans Verkuil Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/coda/coda-bit.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -2257,7 +2257,6 @@ irqreturn_t coda_irq_handler(int irq, vo if (ctx == NULL) { v4l2_err(&dev->v4l2_dev, "Instance released before the end of transaction\n"); - mutex_unlock(&dev->coda_mutex); return IRQ_HANDLED; }