From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780D7C76186 for ; Mon, 29 Jul 2019 20:09:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41CC6205F4 for ; Mon, 29 Jul 2019 20:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564430999; bh=NZBYPz9/upGof+pf+7aPQwh2oUQ15oTbaqLDqA5xc1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=v6nXPMz8/cURaxX7lGgE1CKm6YIWMZmuVLWHoGPzJjjl1YSv0bYYUWNKTb+7XWEl2 3BBFPR0Z7xvAAoVh6EBKz4J/idxGE/0tZBMJ+9vfxtH25PzcVB09AfFWoX7gsV/uCu xsa3D8oY1pMkBP+LSJ64hB/E/v5G7rRGHbSHB6Oc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729678AbfG2Tf2 (ORCPT ); Mon, 29 Jul 2019 15:35:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:49784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388522AbfG2TfZ (ORCPT ); Mon, 29 Jul 2019 15:35:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3084D2070B; Mon, 29 Jul 2019 19:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428924; bh=NZBYPz9/upGof+pf+7aPQwh2oUQ15oTbaqLDqA5xc1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d40CFrdhmvYe5bbr++SM/BhAHinpULqKVz5Hk8ss1HsHr3VbHnSjJQLdqzlRBREt3 bRTTM7TOK/on8XXEoBBrowasy3UY/WdaB0kIRwZIddk1BklHtNQynzJNXAw/quZ2ac bE1N4W9ChPtj5lmdjTNBx9kvIhnYXlxUJs1cMDi0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Wei , "David S. Miller" Subject: [PATCH 4.14 190/293] nfc: fix potential illegal memory access Date: Mon, 29 Jul 2019 21:21:21 +0200 Message-Id: <20190729190839.038041809@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Wei [ Upstream commit dd006fc434e107ef90f7de0db9907cbc1c521645 ] The frags_q is not properly initialized, it may result in illegal memory access when conn_info is NULL. The "goto free_exit" should be replaced by "goto exit". Signed-off-by: Yang Wei Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/nfc/nci/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/nfc/nci/data.c +++ b/net/nfc/nci/data.c @@ -119,7 +119,7 @@ static int nci_queue_tx_data_frags(struc conn_info = nci_get_conn_info_by_conn_id(ndev, conn_id); if (!conn_info) { rc = -EPROTO; - goto free_exit; + goto exit; } __skb_queue_head_init(&frags_q);