From: Tejun Heo <tj@kernel.org>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 3/9] workqueue: require CPU hotplug read exclusion for apply_workqueue_attrs
Date: Mon, 29 Jul 2019 12:47:21 -0700 [thread overview]
Message-ID: <20190729194721.GG569612@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20190725212505.15055-4-daniel.m.jordan@oracle.com>
On Thu, Jul 25, 2019 at 05:24:59PM -0400, Daniel Jordan wrote:
> Change the calling convention for apply_workqueue_attrs to require CPU
> hotplug read exclusion.
>
> Avoids lockdep complaints about nested calls to get_online_cpus in a
> future patch where padata calls apply_workqueue_attrs when changing
> other CPU-hotplug-sensitive data structures with the CPU read lock
> already held.
>
> Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Please feel free to route with the rest of the patchset.
Thanks.
--
tejun
next prev parent reply other threads:[~2019-07-29 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 21:24 [RFC 0/9] padata: use unbound workqueues for parallel jobs Daniel Jordan
2019-07-25 21:24 ` [RFC 1/9] padata: allocate workqueue internally Daniel Jordan
2019-07-25 21:24 ` [RFC 2/9] workqueue: unconfine alloc/apply/free_workqueue_attrs() Daniel Jordan
2019-07-29 19:46 ` Tejun Heo
2019-07-25 21:24 ` [RFC 3/9] workqueue: require CPU hotplug read exclusion for apply_workqueue_attrs Daniel Jordan
2019-07-29 19:47 ` Tejun Heo [this message]
2019-07-30 1:53 ` Daniel Jordan
2019-07-25 21:25 ` [RFC 4/9] padata: make padata_do_parallel find alternate callback CPU Daniel Jordan
2019-07-25 21:25 ` [RFC 5/9] pcrypt: remove padata cpumask notifier Daniel Jordan
2019-07-25 21:25 ` [RFC 6/9] padata, pcrypt: take CPU hotplug lock internally in padata_alloc_possible Daniel Jordan
2019-07-25 21:25 ` [RFC 7/9] padata: use separate workqueues for parallel and serial work Daniel Jordan
2019-07-25 21:25 ` [RFC 8/9] padata: unbind parallel jobs from specific CPUs Daniel Jordan
2019-07-25 21:25 ` [RFC 9/9] padata: remove cpu_index from the parallel_queue Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729194721.GG569612@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=daniel.m.jordan@oracle.com \
--cc=herbert@gondor.apana.org.au \
--cc=jiangshanlai@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).