From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DBCC76186 for ; Mon, 29 Jul 2019 19:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 757CC204EC for ; Mon, 29 Jul 2019 19:53:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XAOt2i5i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403970AbfG2TxO (ORCPT ); Mon, 29 Jul 2019 15:53:14 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42562 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390072AbfG2Twz (ORCPT ); Mon, 29 Jul 2019 15:52:55 -0400 Received: by mail-pg1-f195.google.com with SMTP id t132so28763676pgb.9; Mon, 29 Jul 2019 12:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xtSi5hMWCu8JmvkiHqNyb+90M3Uuthpu/boJgJFrMS8=; b=XAOt2i5iNbNF5eecoaE500/fo2HxMdtBQqKYZ+L9aYfSEx2WcbVxHD7I2bJm0Ude2T Gp/OJfYydHnCaIrDEk6aZfoiJXOPv/KK0pD4yWBERUc2dlsX3DjHQLi4AJ1Ce66nKacM vlJaSkvNg/qJW6oOqeLDYwBp5xy7+O4sytvurgh+iPGzTy52I44L0E/kubboGh/euroy e6UWfHpo7dE4lZC7isJd11/HnPWqySa9V+CZngahHQrEyzHWqIL8cv+GBDUywjUYNN+9 +U9pALSWkZ4TAvjFimWfhFNd9NrWXKLRbYLlduU0rkZkLTdFMwB8OQYH9qEXVYrJU2ZJ qyKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xtSi5hMWCu8JmvkiHqNyb+90M3Uuthpu/boJgJFrMS8=; b=MzsAUOh8UoQXkI28xublwdPMpgik58Isv3YfGMrg/QKDzLDTOwHvIEk6Oz25OE0At2 OKKC2zZt7cuRV0SKmsfASjwo9a7N8CJxMCtN7CaIepmolXvMvKTrE+kXt4sTwEfj+KHc flFUadF4TIY0bFu3gMAxuVuXlMmNlafXqO5/77bwxGBJN/oig3AUyT6ggzccONTSTzZy GvMbHhZWv6gdUvnunwzq5+bzer5dakRLrUW8Nb42s4bbxyO3C1tXyI/2J7e4as1A/BTu V0+d+/v6tRok/Zl434IqAyASA0ljfT37IHUMeo1mRscIFJ86i0bdTUx/DX+ASk6Zj4eI KlYQ== X-Gm-Message-State: APjAAAVAjXLaWYchWEtsw7qfHyzo4b8FTim7Fdmk0W6AdUQBEnLwtdSZ BjfjikCK1vGlUYKWTyZT/crkD2GI X-Google-Smtp-Source: APXvYqzGx/LDBvhX6noBNGjlI/f+61wd2oA06XDK9QEc36Z30+fSnrspzeDUJW1EX6YaRurOpptVaA== X-Received: by 2002:a17:90a:ac13:: with SMTP id o19mr114010053pjq.143.1564429973604; Mon, 29 Jul 2019 12:52:53 -0700 (PDT) Received: from localhost.lan (c-67-185-54-80.hsd1.wa.comcast.net. [67.185.54.80]) by smtp.gmail.com with ESMTPSA id z12sm43983750pfn.29.2019.07.29.12.52.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 12:52:52 -0700 (PDT) From: Andrey Smirnov To: linux-serial@vger.kernel.org Cc: Andrey Smirnov , Stefan Agner , Bhuvanchandra DV , Chris Healy , Cory Tusar , Lucas Stach , Greg Kroah-Hartman , Jiri Slaby , linux-imx@nxp.com, linux-kernel@vger.kernel.org Subject: [PATCH 06/24] tty: serial: fsl_lpuart: Drop unnecessary sg_set_buf() call Date: Mon, 29 Jul 2019 12:52:08 -0700 Message-Id: <20190729195226.8862-7-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190729195226.8862-1-andrew.smirnov@gmail.com> References: <20190729195226.8862-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sg_init_one() will already call sg_set_buf(), so another explicit call right after it is unnecessary. Drop it. Signed-off-by: Andrey Smirnov Cc: Stefan Agner Cc: Bhuvanchandra DV Cc: Chris Healy Cc: Cory Tusar Cc: Lucas Stach Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-imx@nxp.com Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/tty/serial/fsl_lpuart.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 1b3f2a87e558..b600f591c8c2 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1144,7 +1144,6 @@ static inline int lpuart_start_rx_dma(struct lpuart_port *sport) return -ENOMEM; sg_init_one(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); - sg_set_buf(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); nent = dma_map_sg(sport->port.dev, &sport->rx_sgl, 1, DMA_FROM_DEVICE); if (!nent) { -- 2.21.0