From: Nathan Chancellor <natechancellor@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org,
Eli Friedman <efriedma@quicinc.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Hassan Naveed <hnaveed@wavecomp.com>,
Stephen Kitt <steve@sk2.org>,
Serge Semin <fancer.lancer@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base
Date: Mon, 29 Jul 2019 14:15:11 -0700 [thread overview]
Message-ID: <20190729211511.GA74577@archlinux-threadripper> (raw)
In-Reply-To: <20190729211014.39333-1-ndesaulniers@google.com>
On Mon, Jul 29, 2019 at 02:10:12PM -0700, Nick Desaulniers wrote:
> The code in question is modifying a variable declared const through
> pointer manipulation. Such code is explicitly undefined behavior, and
> is the lone issue preventing malta_defconfig from booting when built
> with Clang:
>
> If an attempt is made to modify an object defined with a const-qualified
> type through use of an lvalue with non-const-qualified type, the
> behavior is undefined.
>
> LLVM is removing such assignments. A simple fix is to not declare
> variables const that you plan on modifying. Limiting the scope would be
> a better method of preventing unwanted writes to such a variable.
>
> Further, the code in question mentions "compiler bugs" without any links
> to bug reports, so it is difficult to know if the issue is resolved in
> GCC. The patch was authored in 2006, which would have been GCC 4.0.3 or
> 4.1.1. The minimal supported version of GCC in the Linux kernel is
> currently 4.6.
>
> For what its worth, there was UB before the commit in question, it just
> added a barrier and got lucky IRT codegen. I don't think there's any
> actual compiler bugs related, just runtime bugs due to UB.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/610
> Fixes: 966f4406d903 ("[MIPS] Work around bad code generation for <asm/io.h>.")
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Debugged-by: Nathan Chancellor <natechancellor@gmail.com>
> Suggested-by: Eli Friedman <efriedma@quicinc.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com>
next prev parent reply other threads:[~2019-07-29 21:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:10 [PATCH] mips: avoid explicit UB in assignment of mips_io_port_base Nick Desaulniers
2019-07-29 21:15 ` Nathan Chancellor [this message]
2019-07-29 22:16 ` Maciej W. Rozycki
2019-07-30 17:21 ` Paul Burton
2019-08-07 21:12 ` Nick Desaulniers
2019-08-20 17:15 ` Nick Desaulniers
2019-08-23 17:16 ` Nick Desaulniers
2019-08-24 14:12 ` Paul Burton
2019-08-26 17:31 ` Nick Desaulniers
2019-08-24 14:12 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729211511.GA74577@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=efriedma@quicinc.com \
--cc=fancer.lancer@gmail.com \
--cc=hnaveed@wavecomp.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mhocko@suse.com \
--cc=ndesaulniers@google.com \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=rppt@linux.ibm.com \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).