From: Suren Baghdasaryan <surenb@google.com>
To: mingo@redhat.com, peterz@infradead.org
Cc: lizefan@huawei.com, hannes@cmpxchg.org, axboe@kernel.dk,
dennis@kernel.org, dennisszhou@gmail.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@android.com, Suren Baghdasaryan <surenb@google.com>,
Nick Kralevich <nnk@google.com>
Subject: [PATCH 1/1] psi: do not require setsched permission from the trigger creator
Date: Mon, 29 Jul 2019 18:33:10 -0700 [thread overview]
Message-ID: <20190730013310.162367-1-surenb@google.com> (raw)
When a process creates a new trigger by writing into /proc/pressure/*
files, permissions to write such a file should be used to determine whether
the process is allowed to do so or not. Current implementation would also
require such a process to have setsched capability. Setting of psi trigger
thread's scheduling policy is an implementation detail and should not be
exposed to the user level. Remove the permission check by using _nocheck
version of the function.
Suggested-by: Nick Kralevich <nnk@google.com>
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 7acc632c3b82..ed9a1d573cb1 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -1061,7 +1061,7 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group,
mutex_unlock(&group->trigger_lock);
return ERR_CAST(kworker);
}
- sched_setscheduler(kworker->task, SCHED_FIFO, ¶m);
+ sched_setscheduler_nocheck(kworker->task, SCHED_FIFO, ¶m);
kthread_init_delayed_work(&group->poll_work,
psi_poll_work);
rcu_assign_pointer(group->poll_kworker, kworker);
--
2.22.0.709.g102302147b-goog
next reply other threads:[~2019-07-30 1:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 1:33 Suren Baghdasaryan [this message]
2019-07-30 8:11 ` [PATCH 1/1] psi: do not require setsched permission from the trigger creator Peter Zijlstra
2019-07-30 17:44 ` Suren Baghdasaryan
2019-08-01 9:51 ` Peter Zijlstra
2019-08-01 18:28 ` Suren Baghdasaryan
2019-08-01 21:59 ` Peter Zijlstra
2019-08-02 1:19 ` Suren Baghdasaryan
2019-08-06 11:20 ` [tip:sched/urgent] sched/psi: Do " tip-bot for Suren Baghdasaryan
-- strict thread matches above, loose matches on Subject: below --
2019-07-29 19:42 [PATCH 1/1] psi: do " Suren Baghdasaryan
2019-07-29 19:56 ` Greg KH
2019-07-29 20:11 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730013310.162367-1-surenb@google.com \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dennis@kernel.org \
--cc=dennisszhou@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=nnk@google.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).