From: Andrew Lunn <andrew@lunn.ch>
To: Hubert Feurstein <h.feurstein@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: add support to setup led-control register through device-tree
Date: Tue, 30 Jul 2019 16:09:30 +0200 [thread overview]
Message-ID: <20190730140930.GM28552@lunn.ch> (raw)
In-Reply-To: <20190730101451.845-1-h.feurstein@gmail.com>
On Tue, Jul 30, 2019 at 12:14:50PM +0200, Hubert Feurstein wrote:
> So it is possible to change the default behaviour of the switch LEDs.
Sorry, but this is not going to be accepted. There is an ongoing
discussion about PHY LEDs and how they should be configured. Switch
LEDs are no different from PHY LEDs. So they should use the same basic
concept.
Please take a look at the discussion around:
[RFC] dt-bindings: net: phy: Add subnode for LED configuration
Marvell designers have made this more difficult than it should be by
moving the registers out of the PHY address space and into the switch
address space. So we are going to have to implement this code twice
:-(
Andrew
next prev parent reply other threads:[~2019-07-30 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 10:14 [PATCH 1/2] net: dsa: mv88e6xxx: add support to setup led-control register through device-tree Hubert Feurstein
2019-07-30 10:14 ` [PATCH 2/2] dt-bindings: net: dsa: marvell: add property "marvell,led-control" Hubert Feurstein
2019-07-30 14:09 ` Andrew Lunn [this message]
2019-07-30 15:50 ` [PATCH 1/2] net: dsa: mv88e6xxx: add support to setup led-control register through device-tree Hubert Feurstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730140930.GM28552@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=h.feurstein@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).