From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, matthew.wilcox@oracle.com,
kirill.shutemov@linux.intel.com, oleg@redhat.com,
kernel-team@fb.com, william.kucharski@oracle.com,
srikar@linux.vnet.ibm.com
Subject: Re: [PATCH 2/2] uprobe: collapse THP pmd after removing all uprobes
Date: Tue, 30 Jul 2019 18:01:10 +0300 [thread overview]
Message-ID: <20190730150110.yqib7bawsude2vqt@box> (raw)
In-Reply-To: <20190729054335.3241150-3-songliubraving@fb.com>
On Sun, Jul 28, 2019 at 10:43:35PM -0700, Song Liu wrote:
> After all uprobes are removed from the huge page (with PTE pgtable), it
> is possible to collapse the pmd and benefit from THP again. This patch
> does the collapse by calling khugepaged_add_pte_mapped_thp().
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> kernel/events/uprobes.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> index 58ab7fc7272a..cc53789fefc6 100644
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -26,6 +26,7 @@
> #include <linux/percpu-rwsem.h>
> #include <linux/task_work.h>
> #include <linux/shmem_fs.h>
> +#include <linux/khugepaged.h>
>
> #include <linux/uprobes.h>
>
> @@ -470,6 +471,7 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
> struct page *old_page, *new_page;
> struct vm_area_struct *vma;
> int ret, is_register, ref_ctr_updated = 0;
> + bool orig_page_huge = false;
>
> is_register = is_swbp_insn(&opcode);
> uprobe = container_of(auprobe, struct uprobe, arch);
> @@ -525,6 +527,9 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
>
> /* dec_mm_counter for old_page */
> dec_mm_counter(mm, MM_ANONPAGES);
> +
> + if (PageCompound(orig_page))
> + orig_page_huge = true;
> }
> put_page(orig_page);
> }
> @@ -543,6 +548,10 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
> if (ret && is_register && ref_ctr_updated)
> update_ref_ctr(uprobe, mm, -1);
>
> + /* try collapse pmd for compound page */
> + if (!ret && orig_page_huge)
> + khugepaged_add_pte_mapped_thp(mm, vaddr & HPAGE_PMD_MASK);
> +
IIUC, here you have all locks taken, so you should be able to call
collapse_pte_mapped_thp() directly, shouldn't you?
--
Kirill A. Shutemov
next prev parent reply other threads:[~2019-07-30 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 5:43 [PATCH 0/2] khugepaged: collapse pmd for pte-mapped THP Song Liu
2019-07-29 5:43 ` [PATCH 1/2] khugepaged: enable " Song Liu
2019-07-30 14:59 ` Kirill A. Shutemov
2019-07-30 17:28 ` Song Liu
2019-07-30 18:39 ` Song Liu
2019-07-29 5:43 ` [PATCH 2/2] uprobe: collapse THP pmd after removing all uprobes Song Liu
2019-07-30 15:01 ` Kirill A. Shutemov [this message]
2019-07-30 17:02 ` Song Liu
2019-07-31 16:16 ` Oleg Nesterov
2019-07-31 16:36 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730150110.yqib7bawsude2vqt@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=oleg@redhat.com \
--cc=songliubraving@fb.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).