From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F9AC0650F for ; Tue, 30 Jul 2019 18:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EA522089E for ; Tue, 30 Jul 2019 18:20:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LtjcNupM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729457AbfG3SU0 (ORCPT ); Tue, 30 Jul 2019 14:20:26 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44409 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728824AbfG3SQI (ORCPT ); Tue, 30 Jul 2019 14:16:08 -0400 Received: by mail-pf1-f194.google.com with SMTP id t16so30229479pfe.11 for ; Tue, 30 Jul 2019 11:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aSRdspc9UmTVqUtM/LVhQfTdfVvsFdhNYRk7pu3nDM4=; b=LtjcNupM/HRKM4JoaldcQRTyS2bM2yL9wvKeOG/reX4s7oliVrhZ3wp4wzfzbR4jpA A1CKU4sjWJkHVuwwi/hdtmK5ZPXBxh2NJotGUASyjHj8HoyAh2bkC1ois2SudhmvMElY Y3kLvEzuSI7mA8c4hRjPsl+5oO787lm80ulgc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aSRdspc9UmTVqUtM/LVhQfTdfVvsFdhNYRk7pu3nDM4=; b=ZB7Hab5b9kWM4na5ydN83A4St5QX/4o9jwd/icMHJRuddS+/9LGdAOpbcY7luU6pvm OvXNM31Z/v8GEM9sOJ6VDDjk2WGtkm5xyhNm0OiqvrQXSQZxnnJl8AknhKtQFy+txYeI RHSm6OJftNYFEiRoG0f9Yhv019eFZHSk4meFaNfftGOKrbHXbG618BP+Z/D+DxRjTRQy YxfeQrfntdRdAt0HQIPo4GTFBhzeXKjOuMzHY9uqf9nlCuKC2vC40UxcJzlbfbRzOCSS UvdVbRiCBosKyGHQj+JcXGnuFkmPUDVty4LhzcVzvXZTcRNN0YvBu+k6Z/aUaiAHLnjd E6/g== X-Gm-Message-State: APjAAAUstg1UPYB6Jyo5Hjq07kulBiRkNAF/Fk7E3RfA7/8QwsGHGSeK Jj7yfywpWcsZwj1SNPtA4eA6JeJYTAQ= X-Google-Smtp-Source: APXvYqzl9TiZn1sx5mDRdicXU56NYnmqpjlBsgZoexEMD31JECB2BpobzlnsLFpDz+nGfBgNtl06Yw== X-Received: by 2002:a65:57ca:: with SMTP id q10mr113397707pgr.52.1564510566934; Tue, 30 Jul 2019 11:16:06 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id g1sm106744083pgg.27.2019.07.30.11.16.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 11:16:06 -0700 (PDT) From: Stephen Boyd To: linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , linux-pm@vger.kernel.org, Greg Kroah-Hartman Subject: [PATCH v6 09/57] devfreq: Remove dev_err() usage after platform_get_irq() Date: Tue, 30 Jul 2019 11:15:09 -0700 Message-Id: <20190730181557.90391-10-swboyd@chromium.org> X-Mailer: git-send-email 2.22.0.709.g102302147b-goog In-Reply-To: <20190730181557.90391-1-swboyd@chromium.org> References: <20190730181557.90391-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // While we're here, remove braces on if statements that only have one statement (manually). Cc: MyungJoo Ham Cc: Kyungmin Park Cc: Chanwoo Choi Cc: linux-pm@vger.kernel.org Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/devfreq/tegra-devfreq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c index 35c38aad8b4f..ffd17aba7533 100644 --- a/drivers/devfreq/tegra-devfreq.c +++ b/drivers/devfreq/tegra-devfreq.c @@ -674,10 +674,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); + if (irq < 0) return irq; - } platform_set_drvdata(pdev, tegra); -- Sent by a computer through tubes