From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E829DC433FF for ; Tue, 30 Jul 2019 18:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C128C216C8 for ; Tue, 30 Jul 2019 18:18:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EBEboaQY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729261AbfG3SSw (ORCPT ); Tue, 30 Jul 2019 14:18:52 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:43478 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388001AbfG3SQ1 (ORCPT ); Tue, 30 Jul 2019 14:16:27 -0400 Received: by mail-pl1-f195.google.com with SMTP id 4so22221131pld.10 for ; Tue, 30 Jul 2019 11:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=somlVG7aoLRTDNe0zC2Drx3Tdp0wP3Lq13vd9q8TT1M=; b=EBEboaQYV9O8iIM6zMNzpv8mUeY2ChFjVpMiAksAcInisqCt/i5VHf4CkWOv3Rh05j yinJoKRluXbD7HBvDWEQo53BlbwCh2uTqrm+6a6sZG9Y6cNKub2X27OWEDNdHzsgsnVW VNo4pbLsbAEyIPZpB9FD2B5bD6i3XHgy9nCsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=somlVG7aoLRTDNe0zC2Drx3Tdp0wP3Lq13vd9q8TT1M=; b=r0N4rXC4xF0TvXUSdS7MmWk7Edev+w0rUUZuFpyFzIQs6NIfPucylzJ86ft3iu5RuF Crj7nqDvB3uZExMhGqqPyLfqj37I9I+/uUix/3ubL1GJUgtzOhGJ5qZvrgQzqnO9dNF7 VlKSlzz24/YJXigGdQv14jfvA0MT1QCVetyKHxAwu3gRUzOajudEVUYQdxPdP2LVmWh7 AUOtopm+FqcjcUlPAKJXiuDEx5NRR5EZOK0Ad/HSV1757eeJK+JmAofYIjhV/wK9o6qe brieDOhmxnnifeXeMFEgL2FxtgIprv1pH9RUkFnrF3mTLYw1Lr4HWcz+UVKXguCmj/aY WAuw== X-Gm-Message-State: APjAAAU1AVqimEs7+iBS4PgFy80E0kOeLbN/A99UZqzwSX0ck/8mRWeX OdqjR43sPyYzZgW6uJ4xOTIjyJHlHBI+sg== X-Google-Smtp-Source: APXvYqxIkt5iVgs0+JZCzcg9/Lfm3fKrzE+StmdAm35afC4BtiXz82ANFeNTavglrAZZuqhuLArMMQ== X-Received: by 2002:a17:902:583:: with SMTP id f3mr115777543plf.137.1564510586981; Tue, 30 Jul 2019 11:16:26 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id g1sm106744083pgg.27.2019.07.30.11.16.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 11:16:26 -0700 (PDT) From: Stephen Boyd To: linux-kernel@vger.kernel.org Cc: Linus Walleij , linux-gpio@vger.kernel.org, Greg Kroah-Hartman , Mika Westerberg , Andy Shevchenko Subject: [PATCH v6 34/57] pinctrl: intel: Remove dev_err() usage after platform_get_irq() Date: Tue, 30 Jul 2019 11:15:34 -0700 Message-Id: <20190730181557.90391-35-swboyd@chromium.org> X-Mailer: git-send-email 2.22.0.709.g102302147b-goog In-Reply-To: <20190730181557.90391-1-swboyd@chromium.org> References: <20190730181557.90391-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // While we're here, remove braces on if statements that only have one statement (manually). Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org Cc: Greg Kroah-Hartman Cc: Mika Westerberg Cc: Andy Shevchenko Signed-off-by: Stephen Boyd --- Please apply directly to subsystem trees drivers/pinctrl/intel/pinctrl-cherryview.c | 4 +--- drivers/pinctrl/intel/pinctrl-intel.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 03ec7a5d9d0b..cd4a69b4c5a8 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1703,10 +1703,8 @@ static int chv_pinctrl_probe(struct platform_device *pdev) return PTR_ERR(pctrl->regs); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get interrupt number\n"); + if (irq < 0) return irq; - } pctrl->pctldesc = chv_pinctrl_desc; pctrl->pctldesc.name = dev_name(&pdev->dev); diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index a18d6eefe672..0487e8dc7654 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1354,10 +1354,8 @@ static int intel_pinctrl_probe(struct platform_device *pdev, } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get interrupt number\n"); + if (irq < 0) return irq; - } ret = intel_pinctrl_pm_init(pctrl); if (ret) -- Sent by a computer through tubes