From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED50DC32750 for ; Wed, 31 Jul 2019 02:34:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C121A206E0 for ; Wed, 31 Jul 2019 02:34:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="D+dt/Wwi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbfGaCeY (ORCPT ); Tue, 30 Jul 2019 22:34:24 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49314 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbfGaCeY (ORCPT ); Tue, 30 Jul 2019 22:34:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ORAf6J6JbZKYnL2Jvl8xniqzWNCdzdfxgEVUinGXEAA=; b=D+dt/WwidcTZ/t53+rgaOkq7NL uuTAqcAEvNtjquwzbcddkh0S52df2snmx+NSk3oNX8TgILJg2qLGKoBfu3NWtyIl+fWH1hM2jVtFG 05DL0YnyRLdP8bi+J9lDTT7GFxohUzQIFvQ76kiIICSGHkl7DvtW0AMaxXdttZmOUss4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hseRV-0003nb-Tx; Wed, 31 Jul 2019 04:34:17 +0200 Date: Wed, 31 Jul 2019 04:34:17 +0200 From: Andrew Lunn To: Tao Ren Cc: Vladimir Oltean , Florian Fainelli , Heiner Kallweit , "David S . Miller" , Arun Parameswaran , Justin Chen , netdev , lkml , Andrew Jeffery , "openbmc@lists.ozlabs.org" Subject: Re: [PATCH net-next 2/2] net: phy: broadcom: add 1000Base-X support for BCM54616S Message-ID: <20190731023417.GD9523@lunn.ch> References: <20190730002549.86824-1-taoren@fb.com> <3987251b-9679-dfbe-6e15-f991c2893bac@fb.com> <20190731013636.GC25700@lunn.ch> <885e48dd-df5b-7f08-ef58-557fc2347fa6@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <885e48dd-df5b-7f08-ef58-557fc2347fa6@fb.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Andrew, > > The BCM54616S PHY on my machine is connected to a BCM5396 switch chip over backplane (1000Base-KX). Ah, that is different. So the board is using it for RGMII to 1000Base-KX? phy-mode is about the MAC-PHY link. So in this case RGMII. There is no DT way to configure the PHY-Switch link. However, it sounds like you have the PHY strapped so it is doing 1000BaseX on the PHY-Switch link. So do you actually need to configure this? You report you never see link up? So maybe the problem is actually in read_status? When in 1000BaseX mode, do you need to read the link status from some other register? The Marvell PHYs use a second page for 1000BaseX. Andrew