From: Stefan Mavrodiev <stefan@olimex.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Allwinner sunXi SoC support),
linux-kernel@vger.kernel.org (open list)
Cc: linux-sunxi@googlegroups.com, Stefan Mavrodiev <stefan@olimex.com>
Subject: [PATCH 1/1] nvmem: sunxi_sid: fix A64 SID controller support
Date: Wed, 31 Jul 2019 10:14:47 +0300 [thread overview]
Message-ID: <20190731071447.9019-2-stefan@olimex.com> (raw)
In-Reply-To: <20190731071447.9019-1-stefan@olimex.com>
Like in H3, A64 SID controller doesn't return correct data
when using direct access. It appears that on A64, SID needs
8 bytes of word_size.
Workaround is to enable read by registers.
Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
---
drivers/nvmem/sunxi_sid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c
index a079a80ddf2c..e26ef1bbf198 100644
--- a/drivers/nvmem/sunxi_sid.c
+++ b/drivers/nvmem/sunxi_sid.c
@@ -186,6 +186,7 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg = {
static const struct sunxi_sid_cfg sun50i_a64_cfg = {
.value_offset = 0x200,
.size = 0x100,
+ .need_register_readout = true,
};
static const struct sunxi_sid_cfg sun50i_h6_cfg = {
--
2.17.1
next prev parent reply other threads:[~2019-07-31 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 7:14 [PATCH 0/1] " Stefan Mavrodiev
2019-07-31 7:14 ` Stefan Mavrodiev [this message]
2019-07-31 8:43 ` [PATCH 1/1] " Chen-Yu Tsai
2019-08-01 1:42 ` [linux-sunxi] " Vasily Khoruzhick
2019-08-06 10:03 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731071447.9019-2-stefan@olimex.com \
--to=stefan@olimex.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=wens@csie.org \
--subject='Re: [PATCH 1/1] nvmem: sunxi_sid: fix A64 SID controller support' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).