From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98BD1C32751 for ; Wed, 31 Jul 2019 13:44:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CF8120C01 for ; Wed, 31 Jul 2019 13:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564580665; bh=iFySZK9nAc8gKANTqHzWXIeOjVqsTDqT69nmU5gh3Cg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HEqZjSGsyRLElLIhaxaTkm4PntDRToatMzF5Fv1IJaqbe6CeAzxPe9zLi7DXV+SRG i4hLy+idDZABATE0vGpVXLpDMn3wowMVuNG8gX9cXclx0hVKk6vHJjaU42w7q3C01S V7/XYPCAqMdbY/j25woIKEoFcJLYddTmXcuAOQWg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729640AbfGaNoY (ORCPT ); Wed, 31 Jul 2019 09:44:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:40070 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726907AbfGaNoY (ORCPT ); Wed, 31 Jul 2019 09:44:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B8AA4ABD0; Wed, 31 Jul 2019 13:44:22 +0000 (UTC) Date: Wed, 31 Jul 2019 15:44:22 +0200 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, "Rafael J . Wysocki" , Oscar Salvador , Andrew Morton Subject: Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()" Message-ID: <20190731134422.GS9330@dhcp22.suse.cz> References: <20190731123201.13893-1-david@redhat.com> <20190731125334.GM9330@dhcp22.suse.cz> <20190731131408.GP9330@dhcp22.suse.cz> <23f28590-7765-bcd9-15f2-94e985b64218@redhat.com> <20190731133344.GR9330@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 31-07-19 15:37:56, David Hildenbrand wrote: [...] > The other extreme I saw: People dropping locks because they think they > can be smart but end up making developers debug crashes for months (I am > not lying). Any lock removal should be accompanied with an explanation that is to be a subject of the review. Sure people can make mistakes but there is no way to around it I can see. > As I want to move on with this patch and have other stuff to work on, I > will adjust the comment you gave and add that instead of the lock. Thanks! -- Michal Hocko SUSE Labs