From: Mark Rutland <mark.rutland@arm.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
marc.zyngier@arm.com, james.morse@arm.com,
vladimir.murzin@arm.com, matthias.bgg@gmail.com,
bhsharma@redhat.com
Subject: Re: [RFC v2 8/8] arm64, kexec: enable MMU during kexec relocation
Date: Wed, 31 Jul 2019 16:50:42 +0100 [thread overview]
Message-ID: <20190731155042.GF39768@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190731153857.4045-9-pasha.tatashin@soleen.com>
On Wed, Jul 31, 2019 at 11:38:57AM -0400, Pavel Tatashin wrote:
> +/*
> + * The following code is adoped from "Bare-metal Boot Code for ARMv8-A
> + * Processors Version 1.0, 5.3.1 Cleaning and invalidating the caches".
> + * http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dai0527a
> + */
> +.macro dcache_invalidate tmp0, tmp1, tmp2, tmp3, tmp4, tmp5, tmp6, tmp7, tmp8
> + mov \tmp0, #0x0 /* tmp0 = Cache level */
> + msr CSSELR_EL1, \tmp0 /* 0x0 for L1, 0x2 for L2 */
> + mrs \tmp4, CCSIDR_EL1 /* Read Cache Size ID */
> + and \tmp1, \tmp4, #0x7
> + add \tmp1, \tmp1, #0x4 /* tmp1 Cache Line Size */
> + ldr \tmp3, =0x7fff
> + and \tmp2, \tmp3, \tmp4, lsr #13 /* tmp2 Cache Set num - 1 */
> + ldr \tmp3, =0x3ff
> + and \tmp3, \tmp3, \tmp4, lsr #3 /* tmp3 Cache Assoc. num - 1 */
> + clz \tmp4, \tmp3 /* tmp4 way pos. in the CISW */
> + mov \tmp5, #0 /* tmp5 way counter way_loop */
> +1: /* way_loop */
> + mov \tmp6, #0 /* tmp6 set counter set_loop */
> +2: /* set_loop */
> + lsl \tmp7, \tmp5, \tmp4
> + orr \tmp7, \tmp0, \tmp7 /* Set way */
> + lsl \tmp8, \tmp6, \tmp1
> + orr \tmp7, \tmp7, \tmp8 /* Set set */
> + dc cisw, \tmp7 /* Clean & Inval. cache line */
> + add \tmp6, \tmp6, #1 /* Increment set counter */
> + cmp \tmp6, \tmp2 /* Last set reached yet? */
> + ble 2b /* If not, iterate set_loop, */
> + add \tmp5, \tmp5, #1 /* else, next way. */
> + cmp \tmp5, \tmp3 /* Last way reached yet? */
> + ble 1b /* If not, iterate way_loop. */
> +.endm
> +
For various reasons, one cannot safely use Set/Way operations in
portable code. They only make sense for low-level platform-specific
firmware performing power management operations.
If you need to perform D-cache maintenance, you must use the VA
operations to do so.
Thanks,
Mark.
next prev parent reply other threads:[~2019-07-31 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 15:38 [RFC v2 0/8] arm64: MMU enabled kexec relocation Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 1/8] kexec: quiet down kexec reboot Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 2/8] arm64, mm: transitional tables Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 3/8] arm64: hibernate: switch to transtional page tables Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 4/8] kexec: add machine_kexec_post_load() Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 5/8] arm64, kexec: move relocation function setup and clean up Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 6/8] arm64, kexec: add expandable argument to relocation function Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 7/8] arm64, kexec: configure transitional page table for kexec Pavel Tatashin
2019-07-31 15:38 ` [RFC v2 8/8] arm64, kexec: enable MMU during kexec relocation Pavel Tatashin
2019-07-31 15:50 ` Mark Rutland [this message]
2019-07-31 16:01 ` Pavel Tatashin
2019-07-31 16:32 ` [RFC v2 0/8] arm64: MMU enabled " Mark Rutland
2019-07-31 16:40 ` Pavel Tatashin
2019-07-31 16:50 ` Mark Rutland
2019-07-31 17:04 ` Pavel Tatashin
2019-08-01 13:24 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731155042.GF39768@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=james.morse@arm.com \
--cc=jmorris@namei.org \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=sashal@kernel.org \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).