From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, kan.liang@linux.intel.com
Subject: Re: [PATCH v3 1/7] perf: Allow normal events to be sources of AUX data
Date: Wed, 31 Jul 2019 18:16:44 +0200 [thread overview]
Message-ID: <20190731161644.GW31381@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190731143041.64678-2-alexander.shishkin@linux.intel.com>
On Wed, Jul 31, 2019 at 05:30:35PM +0300, Alexander Shishkin wrote:
> +static void perf_put_aux_event(struct perf_event *event)
> +{
> + struct perf_event_context *ctx = event->ctx;
> + struct perf_cpu_context *cpuctx = __get_cpu_context(ctx);
> + struct perf_event *iter = NULL;
> +
> + /*
> + * If event uses aux_event tear down the link
> + */
> + if (event->aux_event) {
> + put_event(event->aux_event);
> + event->aux_event = NULL;
> + return;
> + }
> +
> + /*
> + * If the event is an aux_event, tear down all links to
> + * it from other events.
> + */
> + for_each_sibling_event(iter, event->group_leader) {
> + if (iter->aux_event != event)
> + continue;
> +
> + iter->aux_event = NULL;
> + put_event(event);
> +
> + /*
> + * If it's ACTIVE, schedule it out. It won't schedule
> + * again because !aux_event.
> + */
> + event_sched_out(iter, cpuctx, ctx);
We should probably do something like:
perf_event_set_state(event, PERF_EVENT_STATE_ERROR);
to avoid these events messing up scheduling for the rest.
> + }
> +}
next prev parent reply other threads:[~2019-07-31 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 14:30 [PATCH v3 0/7] perf, intel: Add support for PEBS output to Intel PT Alexander Shishkin
2019-07-31 14:30 ` [PATCH v3 1/7] perf: Allow normal events to be sources of AUX data Alexander Shishkin
2019-07-31 16:16 ` Peter Zijlstra [this message]
2019-07-31 16:21 ` Peter Zijlstra
2019-07-31 14:30 ` [PATCH v3 2/7] perf/x86/intel: Support PEBS output to PT Alexander Shishkin
2019-07-31 16:50 ` Peter Zijlstra
2019-07-31 14:30 ` [PATCH v3 3/7] perf tools: Add aux_source attribute flag Alexander Shishkin
2019-07-31 14:30 ` [PATCH v3 4/7] perf tools: Add itrace option 'o' to synthesize aux-source events Alexander Shishkin
2019-07-31 14:30 ` [PATCH v3 5/7] perf intel-pt: Process options for PEBS event synthesis Alexander Shishkin
2019-07-31 14:30 ` [PATCH v3 6/7] perf tools: Add aux-source config term Alexander Shishkin
2019-07-31 14:30 ` [PATCH v3 7/7] perf intel-pt: Add brief documentation for PEBS via Intel PT Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731161644.GW31381@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).