From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53867C32753 for ; Wed, 31 Jul 2019 17:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29824206B8 for ; Wed, 31 Jul 2019 17:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564593445; bh=IDr9Fa9DcZN3QqvhuNOkUnI9meArg9GzLkhzynEnQG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CcGeF4NLcZaFiVLsQjV+VYep1Cjm/ocGgY/9w3ajLJ+QZCzyN3v7+5WvSp2eS1Ygd 0JgDSP8zeJrpVnwyOSLfqwUCVWm171MVe0p9YFWW3kT/pCHObvEojJHNhgXtt3JD52 PTJI+NZYFb0LxfwdlYIdOANFJIsc3ww4VOgjD2aM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730580AbfGaRRY (ORCPT ); Wed, 31 Jul 2019 13:17:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:52140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728718AbfGaRRX (ORCPT ); Wed, 31 Jul 2019 13:17:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23C33206A2; Wed, 31 Jul 2019 17:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564593442; bh=IDr9Fa9DcZN3QqvhuNOkUnI9meArg9GzLkhzynEnQG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tK0GSZuV2dT2SKU1ULOz668DWrYR3xwgpzpfEHM3QR8bn19L6uwDrfR+FSBDFb9Mq 254lPC/kEPeoKITXFQpA2dA+szC34Em06JC6fVdMA2wRQh3Cc0vp3+LLuulmnXzt7n rXsec0tt5uuE7hUcnqtdmnMsYXncIo4ASHwiOz2g= Date: Wed, 31 Jul 2019 19:17:20 +0200 From: Greg Kroah-Hartman To: Stephen Boyd Cc: "Rafael J. Wysocki" , Tri Vo , Viresh Kumar , Hridya Valsaraju , Sandeep Patil , Kalesh Singh , Ravi Chandra Sadineni , Linux Kernel Mailing List , Linux PM , "Cc: Android Kernel" , kbuild test robot Subject: Re: [PATCH v5] PM / wakeup: show wakeup sources stats in sysfs Message-ID: <20190731171720.GA15301@kroah.com> References: <20190730024309.233728-1-trong@android.com> <5d40d5b3.1c69fb81.6047f.1cc3@mx.google.com> <3963324.N1Qi0Ay72S@kreacher> <5d41cc55.1c69fb81.9480d.8a49@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d41cc55.1c69fb81.9480d.8a49@mx.google.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 10:13:57AM -0700, Stephen Boyd wrote: > Quoting Rafael J. Wysocki (2019-07-31 04:58:36) > > On Wednesday, July 31, 2019 10:34:11 AM CEST Rafael J. Wysocki wrote: > > > On Wed, Jul 31, 2019 at 1:41 AM Stephen Boyd wrote: > > > > > > > > > > > We can run into the same problem when two buses name their devices the > > > > same name and then we attempt to attach a wakeup source to those two > > > > devices. Or we can have a problem where a virtual wakeup is made with > > > > the same name, and again we'll try to make a duplicate named device. > > > > Using something like 'event' or 'wakeup' or 'ws' as the prefix avoids this > > > > problem and keeps things clean. > > > > > > Or suffix, like ". > > > > > > But if prefixes are used by an existing convention, I would prefer > > > "ws-" as it is concise enough and should not be confusing. > > Another possibility is 'eventN', so it reads as /sys/class/wakeup/event0 "eventX" is a prefix already used by the input subsystem, so you might run into conflicts here :( "wakeupX" makes sense, no namespace colisions there at all. thanks, greg k-h