From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520A6C32751 for ; Wed, 31 Jul 2019 17:32:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2843520679 for ; Wed, 31 Jul 2019 17:32:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cJERArzD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730812AbfGaRc1 (ORCPT ); Wed, 31 Jul 2019 13:32:27 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38849 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730646AbfGaRbU (ORCPT ); Wed, 31 Jul 2019 13:31:20 -0400 Received: by mail-pl1-f194.google.com with SMTP id az7so30770019plb.5; Wed, 31 Jul 2019 10:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/3pXFPCtwTUjw2uGuelbq+/hzvDc+xgZT4R+g9ZoYY8=; b=cJERArzD5sWX5PnWwDZBrI7ud4sX6fwusZ4Qx0YrOurXzZM27KWZ6m4uxQUQdI1AtJ kc7dbmwyIXr9cKKS8pfWMArzHwksSR4z9joeZgTzFKOsY9IjYpAFhjHCcayTvAaRlL5R MjFD1TRAv8/xj7BwARlU2P1BDCcIy2UFaop1kVn+5AJtuCOj6F2mhaGy4sYLgVqwFnQT zYh87m974o5fHeGORtGHaD073CDpxULwpsUBfgNx3/FJZ3iAZmnE2GKk/4FQS8NCPrAC 59JmNtTd7BmZDkBVcUo8NFiM9L1iwWOA2ADBJm3l5WVhg7NjyYdXR+KIKCnq2iMQNvCJ mWHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/3pXFPCtwTUjw2uGuelbq+/hzvDc+xgZT4R+g9ZoYY8=; b=YMRocBAJhbelXqzqBryBi9UGwgo8OzIrjPWZIiirRaGlHn6syejZkOBE3BsOcFkIVJ WcTVCHylQUcbr4MISVFzxvPAKGwKN7fLWUoBaZDtwzu8xzzIqpN74dptnpiJsxG5/Y/a e16CVFBEoOeluTMOhWxqtaMWsTVUkfQpjPUgjZn0OjqGLTphmFy5XebwEe3GQeaICilF 4wtW42sA1KHphcvjgSElmctE/GwN+seMd23zZOU3bsyOhdU1q5DF1BLXA5/3H3sR+mcO XstdOzz/TgLV54Fb96vPHN2cnoomY8nbK/D63mAeoZbpTQ78rk3pv5IlNxcFNx+u4bjB J0sw== X-Gm-Message-State: APjAAAU+f844psxMH/UpBkE1JHHxehsE0QOXzILO4YWIkYAGLpVsFfGV SOoMKXt1zlBR0yk3bwfsSAmtPdaU06M= X-Google-Smtp-Source: APXvYqzEUzrdqa7pHYE3CknrSP5TL2hRjFZlU6yZ6+r4GpMvybuXjKUl4A2oiYi2BihRoFXMMunRsA== X-Received: by 2002:a17:902:6a88:: with SMTP id n8mr121748346plk.70.1564594279289; Wed, 31 Jul 2019 10:31:19 -0700 (PDT) Received: from localhost.localdomain ([2607:fb90:4ad:5a0b:2aff:6e0f:8973:5a26]) by smtp.gmail.com with ESMTPSA id bo20sm2089617pjb.23.2019.07.31.10.31.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 10:31:18 -0700 (PDT) From: Andrey Smirnov To: linux-serial@vger.kernel.org Cc: Andrey Smirnov , Stefan Agner , Chris Healy , Cory Tusar , Lucas Stach , Greg Kroah-Hartman , Jiri Slaby , linux-imx@nxp.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/23] tty: serial: fsl_lpuart: Drop unnecessary uart_write_wakeup() Date: Wed, 31 Jul 2019 10:30:28 -0700 Message-Id: <20190731173045.11718-7-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190731173045.11718-1-andrew.smirnov@gmail.com> References: <20190731173045.11718-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Uart_write_wakeup() will already be called as a part of lpuart*_transmit_buffer() call, so there doesn't seem to be a reason to call it again right after. It also appears that second uart_write_wakeup() might potentially cause unwanted write wakeup when transmitting an x_char. See commit 5e42e9a30cda ("serial: imx: Fix x_char handling and tx flow control") where this problem was fixed in a very similarly structured i.MX UART driver. Signed-off-by: Andrey Smirnov Cc: Stefan Agner Cc: Chris Healy Cc: Cory Tusar Cc: Lucas Stach Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-imx@nxp.com Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/tty/serial/fsl_lpuart.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 57c5825f5de7..c35f81df0cff 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -798,9 +798,6 @@ static void lpuart_txint(struct lpuart_port *sport) else lpuart_transmit_buffer(sport); - if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) - uart_write_wakeup(&sport->port); - out: spin_unlock_irqrestore(&sport->port.lock, flags); } -- 2.21.0