From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 746DFC32751 for ; Wed, 31 Jul 2019 18:14:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 514CB208E4 for ; Wed, 31 Jul 2019 18:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728961AbfGaSOs (ORCPT ); Wed, 31 Jul 2019 14:14:48 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46161 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727167AbfGaSOs (ORCPT ); Wed, 31 Jul 2019 14:14:48 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id EEAD2802F0; Wed, 31 Jul 2019 20:14:33 +0200 (CEST) Date: Wed, 31 Jul 2019 20:14:45 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Vishal Verma , Jane Chu , Dan Williams Subject: Re: [PATCH 4.19 112/113] libnvdimm/bus: Stop holding nvdimm_bus_list_mutex over __nd_ioctl() Message-ID: <20190731181444.GA821@amd> References: <20190729190655.455345569@linuxfoundation.org> <20190729190721.610390670@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PNTmBPCT7hxwcZjr" Content-Disposition: inline In-Reply-To: <20190729190721.610390670@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PNTmBPCT7hxwcZjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-07-29 21:23:19, Greg Kroah-Hartman wrote: > From: Dan Williams >=20 > commit b70d31d054ee3a6fc1034b9d7fc0ae1e481aa018 upstream. >=20 > In preparation for fixing a deadlock between wait_for_bus_probe_idle() > and the nvdimm_bus_list_mutex arrange for __nd_ioctl() without > nvdimm_bus_list_mutex held. This also unifies the 'dimm' and 'bus' level > ioctls into a common nd_ioctl() preamble implementation. Ok, so this is a preparation patch, not a fix... > Marked for -stable as it is a pre-requisite for a follow-on fix. =2E..but follow-on fixes are going to be applied for 5.2 but not 4.19. So perhaps this one should not be in 4.19, either? Best regards, Pavel (Plus its quite complex). > drivers/nvdimm/bus.c | 94 ++++++++++++++++++++++++++++------------= ------- > drivers/nvdimm/nd-core.h | 3 + --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --PNTmBPCT7hxwcZjr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl1B2pQACgkQMOfwapXb+vJpdgCbBAV9m0328rZBqRMvo6K0u83S HvkAni7cGN1XvGoPutUfrRqfcb/9Z14u =BEUc -----END PGP SIGNATURE----- --PNTmBPCT7hxwcZjr--