LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Paul Burton <paul.burton@mips.com>
To: Steven Price <steven.price@arm.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Andy Lutomirski" <luto@kernel.org>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	"Arnd Bergmann" <arnd@arndb.de>, "Borislav Petkov" <bp@alien8.de>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"James Morse" <james.morse@arm.com>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Will Deacon" <will@kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Mark Rutland" <Mark.Rutland@arm.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Ralf Baechle" <ralf@linux-mips.org>,
	"James Hogan" <jhogan@kernel.org>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH v10 05/22] mips: mm: Add p?d_leaf() definitions
Date: Wed, 31 Jul 2019 18:35:54 +0000
Message-ID: <20190731183553.klqcwrvannde5vd7@pburton-laptop> (raw)
In-Reply-To: <20190731154603.41797-6-steven.price@arm.com>

Hi Steven,

On Wed, Jul 31, 2019 at 04:45:46PM +0100, Steven Price wrote:
> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_leaf() functions/macros.
> 
> If _PAGE_HUGE is defined we can simply look for it. When not defined we
> can be confident that there are no leaf pages in existence and fall back
> on the generic implementation (added in a later patch) which returns 0.
> 
> CC: Ralf Baechle <ralf@linux-mips.org>
> CC: Paul Burton <paul.burton@mips.com>
> CC: James Hogan <jhogan@kernel.org>
> CC: linux-mips@vger.kernel.org
> Signed-off-by: Steven Price <steven.price@arm.com>

Acked-by: Paul Burton <paul.burton@mips.com>

Thanks,
    Paul

> ---
>  arch/mips/include/asm/pgtable.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h
> index 7d27194e3b45..238ca243ad31 100644
> --- a/arch/mips/include/asm/pgtable.h
> +++ b/arch/mips/include/asm/pgtable.h
> @@ -627,6 +627,11 @@ static inline pmd_t pmdp_huge_get_and_clear(struct mm_struct *mm,
>  
>  #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>  
> +#ifdef _PAGE_HUGE
> +#define pmd_leaf(pmd)	((pmd_val(pmd) & _PAGE_HUGE) != 0)
> +#define pud_leaf(pud)	((pud_val(pud) & _PAGE_HUGE) != 0)
> +#endif
> +
>  #define gup_fast_permitted(start, end)	(!cpu_has_dc_aliases)
>  
>  #include <asm-generic/pgtable.h>
> -- 
> 2.20.1
> 

  reply index

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 15:45 [PATCH v10 00/22] Generic page walk and ptdump Steven Price
2019-07-31 15:45 ` [PATCH v10 01/22] mm: Add generic p?d_leaf() macros Steven Price
2019-07-31 15:45 ` [PATCH v10 02/22] arc: mm: Add p?d_leaf() definitions Steven Price
2019-07-31 15:45 ` [PATCH v10 03/22] arm: " Steven Price
2019-07-31 15:45 ` [PATCH v10 04/22] arm64: " Steven Price
2019-07-31 15:45 ` [PATCH v10 05/22] mips: " Steven Price
2019-07-31 18:35   ` Paul Burton [this message]
2019-07-31 15:45 ` [PATCH v10 06/22] powerpc: " Steven Price
2019-07-31 15:45 ` [PATCH v10 07/22] riscv: " Steven Price
2019-07-31 15:45 ` [PATCH v10 08/22] s390: " Steven Price
2019-07-31 15:45 ` [PATCH v10 09/22] sparc: " Steven Price
2019-07-31 15:45 ` [PATCH v10 10/22] x86: " Steven Price
2019-07-31 15:45 ` [PATCH v10 11/22] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price
2019-07-31 15:45 ` [PATCH v10 12/22] mm: pagewalk: Allow walking without vma Steven Price
2019-07-31 15:45 ` [PATCH v10 13/22] mm: pagewalk: Add test_p?d callbacks Steven Price
2019-07-31 15:45 ` [PATCH v10 14/22] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price
2019-07-31 15:45 ` [PATCH v10 15/22] x86: mm: Point to struct seq_file from struct pg_state Steven Price
2019-07-31 15:45 ` [PATCH v10 16/22] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price
2019-07-31 15:45 ` [PATCH v10 17/22] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price
2019-07-31 15:45 ` [PATCH v10 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price
2019-07-31 15:46 ` [PATCH v10 19/22] mm: Add generic ptdump Steven Price
2019-07-31 15:46 ` [PATCH v10 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price
2019-08-06 23:58   ` Andrew Morton
2019-08-07 12:58     ` Steven Price
2019-08-07 20:16       ` Andrew Morton
2019-07-31 15:46 ` [PATCH v10 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price
2019-07-31 15:46 ` [PATCH v10 22/22] arm64: mm: Display non-present entries in ptdump Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731183553.klqcwrvannde5vd7@pburton-laptop \
    --to=paul.burton@mips.com \
    --cc=Mark.Rutland@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jglisse@redhat.com \
    --cc=jhogan@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=steven.price@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git