From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039BFC433FF for ; Wed, 31 Jul 2019 22:22:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC46E204EC for ; Wed, 31 Jul 2019 22:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564611760; bh=eRxijePWptzEnqpWtysxuSDWbhdaWYF+Lnq6TrTL2G8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0OHv9BR1d0szRdk72yRt502MeCdfzzBSiMHyzzMPz2/sgqrr3e0TlrkAbgJz+o8/y /IeKwtLNWwTsyWo0ykIxzppsHRFdzEfAT3Nyde4ciugYxLsQ0j6CMh2qyggJ8ncVoo tu+7gISOueNkUMX5LfcgG370jKaDsUpyivkN2gio= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729210AbfGaWWj (ORCPT ); Wed, 31 Jul 2019 18:22:39 -0400 Received: from mga02.intel.com ([134.134.136.20]:38707 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfGaWWi (ORCPT ); Wed, 31 Jul 2019 18:22:38 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 15:22:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,331,1559545200"; d="scan'208";a="371719160" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by fmsmga005.fm.intel.com with ESMTP; 31 Jul 2019 15:22:36 -0700 Date: Wed, 31 Jul 2019 16:19:56 -0600 From: Keith Busch To: "Rafael J. Wysocki" Cc: Mario Limonciello , Kai-Heng Feng , "Rafael J. Wysocki" , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-nvme , Linux PM , Linux Kernel Mailing List , Rajat Jain Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for suspend" has problems Message-ID: <20190731221956.GB15795@localhost.localdomain> References: <4323ed84dd07474eab65699b4d007aaf@AUSX13MPC105.AMER.DELL.COM> <47415939.KV5G6iaeJG@kreacher> <20190730144134.GA12844@localhost.localdomain> <100ba4aff1c6434a81e47774ab4acddc@AUSX13MPC105.AMER.DELL.COM> <8246360B-F7D9-42EB-94FC-82995A769E28@canonical.com> <20190730191934.GD13948@localhost.localdomain> <7d3e0b8ba1444194a153c93faa1cabb3@AUSX13MPC105.AMER.DELL.COM> <20190730213114.GK13948@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 11:25:51PM +0200, Rafael J. Wysocki wrote: > > A couple of remarks if you will. > > First, we don't know which case is the majority at this point. For > now, there is one example of each, but it may very well turn out that > the SK Hynix BC501 above needs to be quirked. > > Second, the reference here really is 5.2, so if there are any systems > that are not better off with 5.3-rc than they were with 5.2, well, we > have not made progress. However, if there are systems that are worse > off with 5.3, that's bad. In the face of the latest findings the only > way to avoid that is to be backwards compatible with 5.2 and that's > where my patch is going. That cannot be achieved by quirking all > cases that are reported as "bad", because there still may be > unreported ones. I have to agree. I think your proposal may allow PCI D3cold, in which case we do need to reintroduce the HMB handling.