linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mason Yang <masonccyang@mxic.com.tw>
Cc: marek.vasut@gmail.com, bbrezillon@kernel.org,
	dwmw2@infradead.org, computersforpeace@gmail.com,
	vigneshr@ti.com, richard@nod.at, robh+dt@kernel.org,
	stefan@agner.ch, mark.rutland@arm.com,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	juliensu@mxic.com.tw, paul.burton@mips.com,
	liang.yang@amlogic.com, lee.jones@linaro.org,
	anders.roxell@linaro.org, christophe.kerello@st.com,
	paul@crapouillou.net, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings
Date: Thu, 1 Aug 2019 09:13:10 +0200	[thread overview]
Message-ID: <20190801091310.035bc824@xps13> (raw)
In-Reply-To: <1564631710-30276-3-git-send-email-masonccyang@mxic.com.tw>

Hi Mason,

Mason Yang <masonccyang@mxic.com.tw> wrote on Thu,  1 Aug 2019 11:55:10
+0800:

> Document the bindings used by the Macronix raw NAND controller.
> 
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
>  Documentation/devicetree/bindings/mtd/mxic-nand.txt | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/mxic-nand.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mxic-nand.txt b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> new file mode 100644
> index 0000000..de37d60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/mxic-nand.txt
> @@ -0,0 +1,19 @@
> +Macronix Raw NAND Controller Device Tree Bindings
> +-------------------------------------------------
> +
> +Required properties:
> +- compatible: should be "mxicy,multi-itfc-v009-nand-morph"
> +- reg: should contain 1 entry for the registers
> +- interrupts: interrupt line connected to this raw NAND controller
> +- clock-names: should contain "ps", "send" and "send_dly"
> +- clocks: should contain 3 phandles for the "ps", "send" and
> +	 "send_dly" clocks
> +
> +Example:
> +
> +	nand: nand-controller@43c30000 {
> +		compatible = "mxicy,multi-itfc-v009-nand-morph";

"mxicy" looks strange to me, I know it has been used in the past and
cannot be removed, but I don't think it is wise to continue using it
while your use "mxic" in all your other contributions. I would update
the prefix to mxic here and fill-in the relevant doc.

Also, what is nand-morph? I thought we were okay for
the "-nand-controller" suffix.


Thanks,
Miquèl

  parent reply	other threads:[~2019-08-01  7:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01  3:55 [PATCH v6 0/2] Add Macronix raw NAND controller driver Mason Yang
2019-08-01  3:55 ` [PATCH v6 1/2] mtd: rawnand: " Mason Yang
2019-08-01  6:22   ` Boris Brezillon
2019-08-05  9:21     ` masonccyang
2019-08-16 10:10     ` masonccyang
2019-08-01  3:55 ` [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings Mason Yang
2019-08-01  5:57   ` Boris Brezillon
2019-08-01  9:17     ` masonccyang
2019-08-01  9:23       ` Boris Brezillon
2019-08-01  7:13   ` Miquel Raynal [this message]
2019-08-01  9:32     ` masonccyang
2019-08-01  9:36       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190801091310.035bc824@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=anders.roxell@linaro.org \
    --cc=bbrezillon@kernel.org \
    --cc=christophe.kerello@st.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=juliensu@mxic.com.tw \
    --cc=lee.jones@linaro.org \
    --cc=liang.yang@amlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=masonccyang@mxic.com.tw \
    --cc=paul.burton@mips.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    --cc=vigneshr@ti.com \
    --subject='Re: [PATCH v6 2/2] dt-bindings: mtd: Document Macronix raw NAND controller bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).