From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 3/5] crypto: Reduce default RT priority
Date: Thu, 01 Aug 2019 13:13:51 +0200 [thread overview]
Message-ID: <20190801111541.800409062@infradead.org> (raw)
In-Reply-To: 20190801111348.530242235@infradead.org
The crypto engine initializes its kworker thread to FIFO-99 (when
requesting RT priority), reduce this to FIFO-50.
FIFO-99 is the very highest priority available to SCHED_FIFO and
it not a suitable default; it would indicate the crypto work is the
most important work on the machine.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
crypto/crypto_engine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/crypto/crypto_engine.c
+++ b/crypto/crypto_engine.c
@@ -425,7 +425,7 @@ EXPORT_SYMBOL_GPL(crypto_engine_stop);
*/
struct crypto_engine *crypto_engine_alloc_init(struct device *dev, bool rt)
{
- struct sched_param param = { .sched_priority = MAX_RT_PRIO - 1 };
+ struct sched_param param = { .sched_priority = MAX_RT_PRIO / 2 };
struct crypto_engine *engine;
if (!dev)
next prev parent reply other threads:[~2019-08-01 11:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 11:13 [PATCH 0/5] Fix FIFO-99 abuse Peter Zijlstra
2019-08-01 11:13 ` [PATCH 1/5] sched/pci: Reduce psimon FIFO priority Peter Zijlstra
2019-08-01 17:49 ` Johannes Weiner
2019-08-01 18:31 ` Suren Baghdasaryan
2019-08-01 21:03 ` Suren Baghdasaryan
2019-08-01 21:02 ` Peter Zijlstra
2019-08-01 11:13 ` [PATCH 2/5] rcu/tree: Fix SCHED_FIFO params Peter Zijlstra
2019-08-01 13:51 ` Paul E. McKenney
2019-08-01 14:43 ` Peter Zijlstra
2019-08-01 15:33 ` Paul E. McKenney
2019-08-01 11:13 ` Peter Zijlstra [this message]
2019-08-09 6:19 ` [PATCH 3/5] crypto: Reduce default RT priority Herbert Xu
2019-08-01 11:13 ` [PATCH 4/5] media/ivtv: Reduce default FIFO priority Peter Zijlstra
2019-08-01 12:24 ` Andy Walls
2019-08-01 12:38 ` Peter Zijlstra
2019-08-02 8:58 ` Peter Zijlstra
2019-08-07 9:26 ` Hans Verkuil
2019-08-01 11:13 ` [PATCH 5/5] spi: Reduce kthread priority Peter Zijlstra
2019-08-01 11:26 ` Mark Brown
2019-08-01 12:07 ` Peter Zijlstra
2019-08-01 11:27 ` Geert Uytterhoeven
2019-08-01 12:12 ` Peter Zijlstra
2019-08-01 12:16 ` Geert Uytterhoeven
2019-08-01 11:27 ` Enric Balletbo i Serra
2019-08-01 12:17 ` Peter Zijlstra
2019-08-01 12:35 ` Mark Brown
2019-08-01 15:44 ` Doug Anderson
2019-08-02 11:22 ` Applied "spi: Reduce kthread priority" to the spi tree Mark Brown
2019-08-01 13:17 ` [PATCH 0/5] Fix FIFO-99 abuse Qais Yousef
2019-08-02 9:32 ` Peter Zijlstra
2019-08-02 9:50 ` Thomas Gleixner
2019-08-02 10:26 ` Qais Yousef
2019-08-02 12:41 ` Peter Zijlstra
2019-08-02 14:08 ` Qais Yousef
2019-08-02 14:33 ` Peter Zijlstra
2019-08-02 15:21 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801111541.800409062@infradead.org \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).