From: Will Deacon <will@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org,
Shawn Anastasio <shawn@anastas.io>,
Michael Ellerman <mpe@ellerman.id.au>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-mapping: fix page attributes for dma_mmap_*
Date: Thu, 1 Aug 2019 17:44:12 +0100 [thread overview]
Message-ID: <20190801164411.kmsl4japtfkgvzxe@willie-the-truck> (raw)
In-Reply-To: <20190801163457.GB26588@lst.de>
On Thu, Aug 01, 2019 at 06:34:57PM +0200, Christoph Hellwig wrote:
> On Thu, Aug 01, 2019 at 05:23:06PM +0100, Will Deacon wrote:
> > > - if (!dev_is_dma_coherent(dev) || (attrs & DMA_ATTR_WRITE_COMBINE))
> > > - return pgprot_writecombine(prot);
> > > - return prot;
> > > + return pgprot_writecombine(prot);
> > > }
> >
> > Seems like a sensible cleanup to me:
> >
> > Acked-by: Will Deacon <will@kernel.org>
> >
> > Although arch_dma_mmap_pgprot() is a bit of a misnomer now that it only
> > gets involved in the non-coherent case.
>
> A better name is welcome.
How about arch_dma_noncoherent_mmap_pgprot() ? Too long?
> My other idea would be to just remove it entirely and do something like:
>
> #ifndef pgprot_dmacoherent
> #define pgprot_dmacoherent pgprot_noncached
> #endif
>
> pgprot_t dma_mmap_pgprot(struct device *dev, pgprot_t prot, unsigned long attrs)
> {
> if (dev_is_dma_coherent(dev) || (attrs & DMA_ATTR_NON_CONSISTENT))
> return prot;
> #ifdef pgprot_writecombine
> if (attrs & DMA_ATTR_WRITE_COMBINE)
> return pgprot_writecombine(prot);
> #endif
> return pgprot_dmacoherent(prot);
> }
Oh, I prefer that!
> But my worry is how this interacts with architectures that have an
> uncached segment (mips, nios2, microblaze, extensa) where we'd have
> the kernel access DMA_ATTR_WRITE_COMBINE mappigns using the uncached
> segment, and userspace mmaps using pgprot_writecombine, which could
> lead to aliasing issues. But then again mips already supports
> DMA_ATTR_WRITE_COMBINE, so this must be ok somehow. I guess I'll
> need to field that question to the relevant parties.
Or it's always been busted and happens to work out in practice...
Will
next prev parent reply other threads:[~2019-08-01 16:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 14:21 fix default dma_mmap_* pgprot Christoph Hellwig
2019-08-01 14:21 ` [PATCH] dma-mapping: fix page attributes for dma_mmap_* Christoph Hellwig
2019-08-01 16:23 ` Will Deacon
2019-08-01 16:34 ` Christoph Hellwig
2019-08-01 16:44 ` Will Deacon [this message]
2019-08-02 8:14 ` Christoph Hellwig
2019-08-02 10:38 ` Will Deacon
2019-08-03 6:48 ` Christoph Hellwig
2019-08-06 16:08 ` Will Deacon
2019-08-06 16:45 ` Russell King - ARM Linux admin
2019-08-06 16:48 ` Russell King - ARM Linux admin
2019-08-07 6:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801164411.kmsl4japtfkgvzxe@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=robin.murphy@arm.com \
--cc=shawn@anastas.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).