From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F1AC433FF for ; Thu, 1 Aug 2019 20:48:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB5AA206B8 for ; Thu, 1 Aug 2019 20:48:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388868AbfHAUsp (ORCPT ); Thu, 1 Aug 2019 16:48:45 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:55757 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbfHAUsp (ORCPT ); Thu, 1 Aug 2019 16:48:45 -0400 Received: from cpe-2606-a000-111b-6140-0-0-0-162e.dyn6.twc.com ([2606:a000:111b:6140::162e] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1htI00-0000tn-VN; Thu, 01 Aug 2019 16:48:39 -0400 Date: Thu, 1 Aug 2019 16:48:04 -0400 From: Neil Horman To: Joe Perches Cc: Vlad Yasevich , Marcelo Ricardo Leitner , "David S. Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sctp: Rename fallthrough label to unhandled Message-ID: <20190801204804.GB11487@hmswarspite.think-freely.org> References: <20190731111932.GA9823@hmswarspite.think-freely.org> <20190731121646.GD9823@hmswarspite.think-freely.org> <20190731205804.GE9823@hmswarspite.think-freely.org> <20190801105051.GA11487@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2019 at 10:42:31AM -0700, Joe Perches wrote: > On Thu, 2019-08-01 at 06:50 -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 03:23:46PM -0700, Joe Perches wrote: > [] > > You can say that if you want, but you made the point that your think the macro > > as you have written is more readable. You example illustrates though that /* > > fallthrough */ is a pretty common comment, and not prefixing it makes it look > > like someone didn't add a comment that they meant to. The __ prefix is standard > > practice for defining macros to attributes (212 instances of it by my count). I > > don't mind rewriting the goto labels at all, but I think consistency is > > valuable. > > Hey Neil. > > Perhaps you want to make this argument on the RFC patch thread > that introduces the fallthrough pseudo-keyword. > > https://lore.kernel.org/patchwork/patch/1108577/ > > > Sure, but it will have to wait for tomorrow at this point, as I need to run to an appointment. Best Neil