From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BBBC32750 for ; Fri, 2 Aug 2019 09:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 809302086A for ; Fri, 2 Aug 2019 09:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564739836; bh=/cln/WIjzGeqOoKndNBd6i8cjt4pYzNDGCPiUMwudic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mmDoik2xg/yy+60kW5GA8z6+cftFheqgRDexpvVDf2eROPZdstO5An0y13gTU+Gz9 OCeaBFERe07nEid8W2p2OEZ/B+tKd5oDZtXTJxRO4yNRNj58ysf+/jTjvZKpJATZWs tvUwKUyxoAsZMJAbw6xrPMxLeCqFvHWbcW5PFSLg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406540AbfHBJ5P (ORCPT ); Fri, 2 Aug 2019 05:57:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:36252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406834AbfHBJ5L (ORCPT ); Fri, 2 Aug 2019 05:57:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88F8C2064A; Fri, 2 Aug 2019 09:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564739830; bh=/cln/WIjzGeqOoKndNBd6i8cjt4pYzNDGCPiUMwudic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q11nj6aYBn9JvjaII22qdcx1Ua2Kk9syF6wu245RZaD+u4Gy6oW9bPvlEfy50gwCk /P8mpD5azMm5id/3HUA+XEx2R52nHryr2Dn9G0EC7ZFV7Fj6RfP70kEfLHTyYK0y3Z ypXdL0qLB+FDsZpJc5uYDbG7NL1AaHUnEneBvALY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yan, Zheng" , Jeff Layton , Ilya Dryomov Subject: [PATCH 4.19 30/32] ceph: hold i_ceph_lock when removing caps for freeing inode Date: Fri, 2 Aug 2019 11:40:04 +0200 Message-Id: <20190802092111.124929517@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190802092101.913646560@linuxfoundation.org> References: <20190802092101.913646560@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yan, Zheng commit d6e47819721ae2d9d090058ad5570a66f3c42e39 upstream. ceph_d_revalidate(, LOOKUP_RCU) may call __ceph_caps_issued_mask() on a freeing inode. Signed-off-by: "Yan, Zheng" Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/caps.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -1237,20 +1237,23 @@ static int send_cap_msg(struct cap_msg_a } /* - * Queue cap releases when an inode is dropped from our cache. Since - * inode is about to be destroyed, there is no need for i_ceph_lock. + * Queue cap releases when an inode is dropped from our cache. */ void ceph_queue_caps_release(struct inode *inode) { struct ceph_inode_info *ci = ceph_inode(inode); struct rb_node *p; + /* lock i_ceph_lock, because ceph_d_revalidate(..., LOOKUP_RCU) + * may call __ceph_caps_issued_mask() on a freeing inode. */ + spin_lock(&ci->i_ceph_lock); p = rb_first(&ci->i_caps); while (p) { struct ceph_cap *cap = rb_entry(p, struct ceph_cap, ci_node); p = rb_next(p); __ceph_remove_cap(cap, true); } + spin_unlock(&ci->i_ceph_lock); } /*