linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib
@ 2019-08-02 10:04 Schrempf Frieder
  2019-08-02 10:04 ` [PATCH v3 2/4] serial: mctrl_gpio: Add a NULL check to mctrl_gpio_to_gpiod() Schrempf Frieder
                   ` (4 more replies)
  0 siblings, 5 replies; 15+ messages in thread
From: Schrempf Frieder @ 2019-08-02 10:04 UTC (permalink / raw)
  To: u.kleine-koenig, shawnguo, s.hauer, kernel, festevam, linux-imx,
	Greg Kroah-Hartman
  Cc: linux-arm-kernel, geert+renesas, Schrempf Frieder, Jiri Slaby,
	linux-serial, linux-kernel

From: Frieder Schrempf <frieder.schrempf@kontron.de>

If CONFIG_GPIOLIB is not enabled, mctrl_gpio_init() and
mctrl_gpio_init_noauto() will currently return an error pointer with
-ENOSYS. As the mctrl GPIOs are usually optional, drivers need to
check for this condition to allow continue probing.

To avoid the need for this check in each driver, we return NULL
instead, as all the mctrl_gpio_*() functions are skipped anyway.
We also adapt mctrl_gpio_to_gpiod() to be in line with this change.

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
Changes in v3
=============
* Move the changes in mctrl_gpio_to_gpiod() to a separate patch
* Reorder tags

Changes in v2
=============
* Move the sh_sci changes to a separate patch
* Add Fabio's R-b tag
---
 drivers/tty/serial/serial_mctrl_gpio.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h
index b7d3cca48ede..1b2ff503b2c2 100644
--- a/drivers/tty/serial/serial_mctrl_gpio.h
+++ b/drivers/tty/serial/serial_mctrl_gpio.h
@@ -114,19 +114,19 @@ static inline
 struct gpio_desc *mctrl_gpio_to_gpiod(struct mctrl_gpios *gpios,
 				      enum mctrl_gpio_idx gidx)
 {
-	return ERR_PTR(-ENOSYS);
+	return NULL;
 }
 
 static inline
 struct mctrl_gpios *mctrl_gpio_init(struct uart_port *port, unsigned int idx)
 {
-	return ERR_PTR(-ENOSYS);
+	return NULL;
 }
 
 static inline
 struct mctrl_gpios *mctrl_gpio_init_noauto(struct device *dev, unsigned int idx)
 {
-	return ERR_PTR(-ENOSYS);
+	return NULL;
 }
 
 static inline
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-08-06  8:10 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 10:04 [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 2/4] serial: mctrl_gpio: Add a NULL check to mctrl_gpio_to_gpiod() Schrempf Frieder
2019-08-02 12:12   ` Uwe Kleine-König
2019-08-05  9:01     ` Schrempf Frieder
2019-08-06  7:45       ` Uwe Kleine-König
2019-08-06  8:02         ` Schrempf Frieder
2019-08-02 10:04 ` [PATCH v3 3/4] serial: sh-sci: Don't check for mctrl_gpio_init() returning -ENOSYS Schrempf Frieder
2019-08-02 12:13   ` Uwe Kleine-König
2019-08-06  8:09   ` Geert Uytterhoeven
2019-08-02 10:04 ` [PATCH v3 4/4] serial: 8250: " Schrempf Frieder
2019-08-02 12:15   ` Uwe Kleine-König
2019-08-02 12:26     ` Greg Kroah-Hartman
2019-08-06  7:44       ` Uwe Kleine-König
2019-08-02 12:08 ` [PATCH v3 1/4] serial: mctrl_gpio: Avoid probe failures in case of missing gpiolib Uwe Kleine-König
2019-08-06  8:09 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).