From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93548C433FF for ; Fri, 2 Aug 2019 17:42:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C059217F5 for ; Fri, 2 Aug 2019 17:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405877AbfHBRmc (ORCPT ); Fri, 2 Aug 2019 13:42:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:48972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405681AbfHBRmb (ORCPT ); Fri, 2 Aug 2019 13:42:31 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FE11217F5; Fri, 2 Aug 2019 17:42:30 +0000 (UTC) Date: Fri, 2 Aug 2019 13:42:28 -0400 From: Steven Rostedt To: Divya Indi Cc: linux-kernel@vger.kernel.org, Joe Jin , Aruna Ramakrishna , Srinivas Eeda Subject: Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event Message-ID: <20190802134229.2a969047@gandalf.local.home> In-Reply-To: <8e50d405-a4fb-fadf-509e-157b031d7542@oracle.com> References: <1564444954-28685-1-git-send-email-divya.indi@oracle.com> <1564444954-28685-8-git-send-email-divya.indi@oracle.com> <20190729205138.689864d2@gandalf.local.home> <8e50d405-a4fb-fadf-509e-157b031d7542@oracle.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Jul 2019 15:29:41 -0700 Divya Indi wrote: > Hi Steven, > > On 7/29/19 5:51 PM, Steven Rostedt wrote: > > On Mon, 29 Jul 2019 17:02:34 -0700 > > Divya Indi wrote: > > > >> Use "trace_array_set_clr_event" to enable/disable events to a trace > >> array from other kernel modules/components. > >> Hence, we no longer need to have ftrace_set_clr_event as an exported API. > > Hmm, this simply reverts patch 1. Why have patch 1 and this patch in > > the first place? > > Right! First patch fixes issues in a previous commit and then this patch > reverts the part of previous commit that required the fix. > > We can eliminate the first patch if it seems counter intuitive. > > As a stand alone patch, the first one may be fine. But as part of a series, it doesn't make sense to add it. -- Steve