Re: [PATCH -next 05/12] crypto: inside-secure - use devm_platform_ioremap_resource() to simplify code

From: Antoine Tenart <antoine.tenart@bootlin.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: herbert@gondor.apana.org.au, lars.persson@axis.com,
	jesper.nilsson@axis.com, davem@davemloft.net,
	thomas.lendacky@amd.com, gary.hook@amd.com, krzk@kernel.org,
	kgene@kernel.org, antoine.tenart@bootlin.com,
	matthias.bgg@gmail.com, jamie@jamieiles.com, agross@kernel.org,
	heiko@sntech.de, mcoquelin.stm32@gmail.com,
	alexandre.torgue@st.com, clabbe.montjoie@gmail.com,
	mripard@kernel.org, wens@csie.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, linux-arm-kernel@axis.com,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH -next 05/12] crypto: inside-secure - use devm_platform_ioremap_resource() to simplify code
Date: Fri, 2 Aug 2019 18:17:01 +0200	[thread overview]
Message-ID: <20190802161701.GD14470@kwain> (raw)
In-Reply-To: <20190802132809.8116-6-yuehaibing@huawei.com>

Hello,

On Fri, Aug 02, 2019 at 09:28:02PM +0800, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>

Thanks,
Antoine

> ---
>  drivers/crypto/inside-secure/safexcel.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index d1f60fd..822744d 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -999,7 +999,6 @@ static void safexcel_init_register_offsets(struct safexcel_crypto_priv *priv)
>  static int safexcel_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> -	struct resource *res;
>  	struct safexcel_crypto_priv *priv;
>  	int i, ret;
>  
> @@ -1015,8 +1014,7 @@ static int safexcel_probe(struct platform_device *pdev)
>  
>  	safexcel_init_register_offsets(priv);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	priv->base = devm_ioremap_resource(dev, res);
> +	priv->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(priv->base)) {
>  		dev_err(dev, "failed to get resource\n");
>  		return PTR_ERR(priv->base);
> -- 
> 2.7.4
> 
> 

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com