From: Steven Rostedt <rostedt@goodmis.org>
To: Divya Indi <divya.indi@oracle.com>
Cc: linux-kernel@vger.kernel.org, Joe Jin <joe.jin@oracle.com>,
Aruna Ramakrishna <aruna.ramakrishna@oracle.com>,
Srinivas Eeda <srinivas.eeda@oracle.com>
Subject: Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event
Date: Fri, 2 Aug 2019 17:25:08 -0400 [thread overview]
Message-ID: <20190802172508.10e829d6@gandalf.local.home> (raw)
In-Reply-To: <87e1a9b8-9f72-c240-9b9a-2d454046e2f3@oracle.com>
On Fri, 2 Aug 2019 14:12:54 -0700
Divya Indi <divya.indi@oracle.com> wrote:
> Hi Steve,
>
> The first patch would be like a temporary fix in case we need more
> changes to the patches that add the new function - trace_array_set_clr()
> and unexport ftrace_set_clr_event() and might take some time. In which
> case I think it would be good to have this in place (But, not part of
> this series).
>
> If they all are to go in together as part of the same release ie if all
> is good with the concerned patches (Patch 6 & Patch 7), then I think
> having this patch would be meaningless.
Can you just do this part of patch 6 instead?
+/**
+ * trace_array_set_clr_event - enable or disable an event for a trace array
+ * @system: system name to match (NULL for any system)
+ * @event: event name to match (NULL for all events, within system)
+ * @set: 1 to enable, 0 to disable
+ *
+ * This is a way for other parts of the kernel to enable or disable
+ * event recording to instances.
+ *
+ * Returns 0 on success, -EINVAL if the parameters do not match any
+ * registered events.
+ */
+int trace_array_set_clr_event(struct trace_array *tr, const char *system,
+ const char *event, int set)
+{
+ if (!tr)
+ return -ENOENT;
+
+ return __ftrace_set_clr_event(tr, NULL, system, event, set);
+}
+EXPORT_SYMBOL_GPL(trace_array_set_clr_event);
+
-- Steve
next prev parent reply other threads:[~2019-08-02 21:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 0:02 [PATCH 0/7[v3]] Kernel access to Ftrace instances Divya Indi
2019-07-30 0:02 ` [PATCH 1/7] tracing: Required changes to use ftrace_set_clr_event Divya Indi
2019-07-30 0:02 ` [PATCH 2/7] tracing: Declare newly exported APIs in include/linux/trace.h Divya Indi
2019-07-30 0:02 ` [PATCH 3/7] tracing: Verify if trace array exists before destroying it Divya Indi
2019-07-30 0:02 ` [PATCH 4/7] tracing: Adding NULL checks Divya Indi
2019-07-30 0:02 ` [PATCH 5/7] tracing: Handle the trace array ref counter in new functions Divya Indi
2019-07-30 0:02 ` [PATCH 6/7] tracing: New functions for kernel access to Ftrace instances Divya Indi
2019-07-30 0:02 ` [PATCH 7/7] tracing: Un-export ftrace_set_clr_event Divya Indi
2019-07-30 0:51 ` Steven Rostedt
2019-07-30 22:29 ` Divya Indi
2019-08-02 17:42 ` Steven Rostedt
[not found] ` <291a12f6-e1eb-052e-0dd6-0e649dd4a752@oracle.com>
2019-08-02 20:46 ` Steven Rostedt
2019-08-02 21:12 ` Divya Indi
2019-08-02 21:25 ` Steven Rostedt [this message]
2019-08-07 18:13 ` Divya Indi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802172508.10e829d6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=aruna.ramakrishna@oracle.com \
--cc=divya.indi@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.eeda@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).