From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995ACC32750 for ; Fri, 2 Aug 2019 18:18:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6613C20880 for ; Fri, 2 Aug 2019 18:18:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="POWpG2um" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406668AbfHBSSs (ORCPT ); Fri, 2 Aug 2019 14:18:48 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57634 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405976AbfHBSSs (ORCPT ); Fri, 2 Aug 2019 14:18:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JCYZVC/M3FiIjiwcLsQNRgrwzjn8oD0+t2wbx/4yCkY=; b=POWpG2umKb7U6UMpO9yXJOhHmd HQxcSzbnaPrg+WkF1dGL7YSS3DpZtl7+04FZEubHBMvQDhQwtDmbToGqQW3FIRgW3m6/iCAPt9DMw B9a+GxlZnoTUV4WEua+5Vuibii9KHivZ2+VjQGx7jcV6z6Bj3TOlWvu6mPItX/MFObM8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1htc8W-0002qb-9p; Fri, 02 Aug 2019 20:18:40 +0200 Date: Fri, 2 Aug 2019 20:18:40 +0200 From: Andrew Lunn To: Matthias Kaehlcke Cc: "David S . Miller" , Rob Herring , Mark Rutland , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH v4 4/4] net: phy: realtek: configure RTL8211E LEDs Message-ID: <20190802181840.GP2099@lunn.ch> References: <20190801190759.28201-1-mka@chromium.org> <20190801190759.28201-5-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190801190759.28201-5-mka@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 01, 2019 at 12:07:59PM -0700, Matthias Kaehlcke wrote: > Configure the RTL8211E LEDs behavior when the device tree property > 'realtek,led-modes' is specified. > > Signed-off-by: Matthias Kaehlcke Hi Matthias I was more thinking of adding a new driver call to the PHY driver API, to configure an LED. Something like rtl8211e_config_leds(phydev, int led, struct phy_led_config cfg); It would be called by the phylib core after config_init(). But also, thinking ahead to generic linux LED support, it could be called later to reconfigure the LEDs to use a different trigger. The standard LED sysfs interface would be used. Andrew