* [PATCH] staging: isdn: remove unnecessary parentheses
@ 2019-08-02 20:23 Thiago Bonotto
2019-08-05 14:50 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Thiago Bonotto @ 2019-08-02 20:23 UTC (permalink / raw)
To: Karsten Keil, Greg Kroah-Hartman, netdev, devel, linux-kernel, lkcamp
Fix the following checkpatch error:
ERROR: return is not a function, parentheses are not required
FILE: drivers/staging/isdn/hysdn/hysdn_net.c:289:
+ return (0); /* and return success */
Signed-off-by: Thiago Bonotto <thbonotto@gmail.com>
---
Hello, this is my first contribution :)
Thanks for reviewing
drivers/staging/isdn/hysdn/hysdn_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/isdn/hysdn/hysdn_net.c b/drivers/staging/isdn/hysdn/hysdn_net.c
index bea37ae30..dcb9ef7a2 100644
--- a/drivers/staging/isdn/hysdn/hysdn_net.c
+++ b/drivers/staging/isdn/hysdn/hysdn_net.c
@@ -286,7 +286,7 @@ hysdn_net_create(hysdn_card *card)
if (card->debug_flags & LOG_NET_INIT)
hysdn_addlog(card, "network device created");
- return (0); /* and return success */
+ return 0; /* and return success */
} /* hysdn_net_create */
/***************************************************************************/
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: isdn: remove unnecessary parentheses
2019-08-02 20:23 [PATCH] staging: isdn: remove unnecessary parentheses Thiago Bonotto
@ 2019-08-05 14:50 ` Dan Carpenter
2019-08-05 18:51 ` [Lkcamp] " Helen Koike
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2019-08-05 14:50 UTC (permalink / raw)
To: Thiago Bonotto
Cc: Karsten Keil, Greg Kroah-Hartman, netdev, devel, linux-kernel, lkcamp
This driver is obselete so we're just keeping it around for a couple
kernel releases and then deleting it. We're not taking cleanups for it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Lkcamp] [PATCH] staging: isdn: remove unnecessary parentheses
2019-08-05 14:50 ` Dan Carpenter
@ 2019-08-05 18:51 ` Helen Koike
0 siblings, 0 replies; 3+ messages in thread
From: Helen Koike @ 2019-08-05 18:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Thiago Bonotto, devel, Karsten Keil, Greg Kroah-Hartman,
linux-kernel, lkcamp, netdev
Hi,
On Mon, Aug 5, 2019 at 11:51 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> This driver is obselete so we're just keeping it around for a couple
> kernel releases and then deleting it. We're not taking cleanups for it.
I'm sorry, it was me who suggested Thiago to make this change
as his first contribution, I didn't see the TODO file.
Thiago, it would be great if you could send a patch to another staging driver
to get starting and to learn how the kernel development cycle works.
Feel free to ping me or the lkcamp group if you want some pointers/guidance.
Thanks both for your contribution.
Helen
>
> regards,
> dan carpenter
>
>
> _______________________________________________
> Lkcamp mailing list
> Lkcamp@lists.libreplanetbr.org
> https://lists.libreplanetbr.org/mailman/listinfo/lkcamp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-05 18:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-02 20:23 [PATCH] staging: isdn: remove unnecessary parentheses Thiago Bonotto
2019-08-05 14:50 ` Dan Carpenter
2019-08-05 18:51 ` [Lkcamp] " Helen Koike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).