From: Christoph Hellwig <hch@lst.de>
To: Rob Clark <robdclark@chromium.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Rob Clark <robdclark@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: please revert "drm/msm: Use the correct dma_sync calls in msm_gem"
Date: Fri, 2 Aug 2019 23:37:56 +0200 [thread overview]
Message-ID: <20190802213756.GA20033@lst.de> (raw)
Hi Rob,
I just saw your above commit in Linus' tree, which is completely
bogus and misunderstand the DMA API. Next time you have any issues
please Cc the relevant maintainers and mailing lists. But even
more importantly get_dma_ops is an completely internal API, and
whatevet your helpers are trying to do is bad - if the dma wasn't
mapped at the time you call the new sync_for_device helper, this
is broken because you can't call dma_sync_sg_for_device on unmapped
address. If it was mapped it is bogus as well as you can't double
map it. Please describe what you're actually trying to fix and we're
going to work on a proper solution, but this shot from the hip is just
going to make things worse.
next reply other threads:[~2019-08-02 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 21:37 Christoph Hellwig [this message]
2019-08-02 22:06 ` please revert "drm/msm: Use the correct dma_sync calls in msm_gem" Rob Clark
2019-08-03 6:19 ` Christoph Hellwig
2019-08-03 14:47 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802213756.GA20033@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=seanpaul@chromium.org \
--cc=stephan@gerhold.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).