From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52CFC433FF for ; Sun, 4 Aug 2019 15:04:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD12A2070D for ; Sun, 4 Aug 2019 15:04:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="sspKmymJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726440AbfHDPER (ORCPT ); Sun, 4 Aug 2019 11:04:17 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:59802 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726181AbfHDPER (ORCPT ); Sun, 4 Aug 2019 11:04:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9YmikpTEpr5D1kpfN5dBORPimRY5G5XZGxcVzG0I71E=; b=sspKmymJGZKyjEHU4QnsfXYY76 Q2i1TaxOrrITR9iSoME1XCUXeqEjE4k83TV2x0Q9W/xoaFALuH5E+lwtSQRed+T7gFn6UY1kbbEuW gMxQPRzHSsppP3vmlVagR1MvTM0Ir/xR7ST7MwOY87thZjkW0XlRnSfBJDPY4+ej98TA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1huI3S-000248-Lh; Sun, 04 Aug 2019 17:04:14 +0200 Date: Sun, 4 Aug 2019 17:04:14 +0200 From: Andrew Lunn To: Hubert Feurstein Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vivien Didelot , Florian Fainelli , "David S. Miller" Subject: Re: [PATCH net] net: dsa: mv88e6xxx: drop adjust_link to enabled phylink Message-ID: <20190804150414.GC6800@lunn.ch> References: <20190731154239.19270-1-h.feurstein@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731154239.19270-1-h.feurstein@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 05:42:39PM +0200, Hubert Feurstein wrote: > We have to drop the adjust_link callback in order to finally migrate to > phylink. > > Otherwise we get the following warning during startup: > "mv88e6xxx 2188000.ethernet-1:10: Using legacy PHYLIB callbacks. Please > migrate to PHYLINK!" > > The warning is generated in the function dsa_port_link_register_of in > dsa/port.c: > > int dsa_port_link_register_of(struct dsa_port *dp) > { > struct dsa_switch *ds = dp->ds; > > if (!ds->ops->adjust_link) > return dsa_port_phylink_register(dp); > > dev_warn(ds->dev, > "Using legacy PHYLIB callbacks. Please migrate to PHYLINK!\n"); > [...] > } > > Signed-off-by: Hubert Feurstein Reviewed-by: Andrew Lunn Andrew