From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F82C433FF for ; Mon, 5 Aug 2019 17:30:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3115208E3 for ; Mon, 5 Aug 2019 17:30:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729981AbfHERaE (ORCPT ); Mon, 5 Aug 2019 13:30:04 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59576 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbfHERaD (ORCPT ); Mon, 5 Aug 2019 13:30:03 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 23CE5154080F5; Mon, 5 Aug 2019 10:30:03 -0700 (PDT) Date: Mon, 05 Aug 2019 10:30:02 -0700 (PDT) Message-Id: <20190805.103002.641507066504156536.davem@davemloft.net> To: maowenan@huawei.com Cc: socketcan@hartkopp.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next v3] net: can: Fix compiling warnings for two functions From: David Miller In-Reply-To: <20190805115744.112440-1-maowenan@huawei.com> References: <6fd68e9b-a8ae-4e5e-9b23-c099b5ca9aa4@web.de> <20190805115744.112440-1-maowenan@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Aug 2019 10:30:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan Date: Mon, 5 Aug 2019 19:57:44 +0800 > @@ -1680,7 +1680,7 @@ static int bcm_recvmsg(struct socket *sock, struct msghdr *msg, size_t size, > return size; > } > > -int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, > +static int bcm_sock_no_ioctlcmd(struct socket *sock, unsigned int cmd, > unsigned long arg) The alignment of the second line here needs to be adjusted, it must start precisely at the first column after the openning parenthesis of the first line. Same for the other change in this patch.