From: David Miller <davem@davemloft.net>
To: mcroce@redhat.com
Cc: netdev@vger.kernel.org, miquel.raynal@free-electrons.com,
linux-kernel@vger.kernel.org, lorenzo@kernel.org,
antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com
Subject: Re: [PATCH net] mvpp2: fix panic on module removal
Date: Mon, 05 Aug 2019 13:54:19 -0700 (PDT) [thread overview]
Message-ID: <20190805.135419.2048746821760453181.davem@davemloft.net> (raw)
In-Reply-To: <CAGnkfhxRV=2G6Sxf_nZQekeXLsf64QkKqfN-9pN_Mi6Y+=nXRA@mail.gmail.com>
From: Matteo Croce <mcroce@redhat.com>
Date: Mon, 5 Aug 2019 20:17:39 +0200
> On Mon, Aug 5, 2019 at 7:58 PM David Miller <davem@davemloft.net> wrote:
>>
>> From: Matteo Croce <mcroce@redhat.com>
>> Date: Wed, 31 Jul 2019 20:31:16 +0200
>>
>> > mvpp2 uses a delayed workqueue to gather traffic statistics.
>> > On module removal the workqueue can be destroyed before calling
>> > cancel_delayed_work_sync() on its works.
>> > Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
>>
>> Please post a new version with the flush_workqueue() removed.
>
> Hi,
>
> I thought that it was already merged:
>
> https://lore.kernel.org/netdev/20190801121330.30823-1-mcroce@redhat.com/
>
> Let me know if it's ok already.
Oops, my bad. :-)
prev parent reply other threads:[~2019-08-05 20:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 18:31 [PATCH net] mvpp2: fix panic on module removal Matteo Croce
2019-08-01 7:18 ` Antoine Tenart
2019-08-01 11:46 ` Matteo Croce
2019-08-01 12:00 ` Antoine Tenart
2019-08-05 17:58 ` David Miller
2019-08-05 18:17 ` Matteo Croce
2019-08-05 20:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805.135419.2048746821760453181.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antoine.tenart@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mcroce@redhat.com \
--cc=miquel.raynal@free-electrons.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).