From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37AC1C433FF for ; Mon, 5 Aug 2019 13:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 090502087B for ; Mon, 5 Aug 2019 13:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010415; bh=1HpjSYwLan9OrxS7SyHBTzZANBPjlOwsdKC5zB/Y+xQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rjdWewiijHNyjY7mXNZOYmHkLM08cx1l5vjDm4+gDEeUZ7qWrNDBH2Lx1yIvK7RKE OZDAh+CKX10xj3K2kJPyM/IWgvh98BEwppJH4t0Gk8YDiSi4fc04MHFo/0Kre8Gptq XNSoUW7VDrcNazSXxk9xtGdv0wvNXv8cyb3HV8+A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729711AbfHENGx (ORCPT ); Mon, 5 Aug 2019 09:06:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:43880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729698AbfHENGu (ORCPT ); Mon, 5 Aug 2019 09:06:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 552C0206C1; Mon, 5 Aug 2019 13:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010409; bh=1HpjSYwLan9OrxS7SyHBTzZANBPjlOwsdKC5zB/Y+xQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vK4sEEUElJD3WHuBsEYXjjzp5Ff/7HPGsWVT6wA3J75ZoItR1TXrcit9bpPbD1th3 AgaFK/01ZxRc/oUUFk687D0KyxkDjzQTRCU3gTQAZWaOR9NRLKX3b3mmfhTFcBRU5l j7D8upCkfAqX2mJxTIYhI7/DMNtoHDxSgW5pdhhw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Paul E. McKenney" , Peter Zijlstra , Andrea Parri , "Yan, Zheng" , Ilya Dryomov , Sasha Levin Subject: [PATCH 4.14 13/53] ceph: fix improper use of smp_mb__before_atomic() Date: Mon, 5 Aug 2019 15:02:38 +0200 Message-Id: <20190805124929.575764614@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190805124927.973499541@linuxfoundation.org> References: <20190805124927.973499541@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 749607731e26dfb2558118038c40e9c0c80d23b5 ] This barrier only applies to the read-modify-write operations; in particular, it does not apply to the atomic64_set() primitive. Replace the barrier with an smp_mb(). Fixes: fdd4e15838e59 ("ceph: rework dcache readdir") Reported-by: "Paul E. McKenney" Reported-by: Peter Zijlstra Signed-off-by: Andrea Parri Reviewed-by: "Yan, Zheng" Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/super.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/ceph/super.h b/fs/ceph/super.h index 3e27a28aa44ad..60b70f0985f67 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h @@ -517,7 +517,12 @@ static inline void __ceph_dir_set_complete(struct ceph_inode_info *ci, long long release_count, long long ordered_count) { - smp_mb__before_atomic(); + /* + * Makes sure operations that setup readdir cache (update page + * cache and i_size) are strongly ordered w.r.t. the following + * atomic64_set() operations. + */ + smp_mb(); atomic64_set(&ci->i_complete_seq[0], release_count); atomic64_set(&ci->i_complete_seq[1], ordered_count); } -- 2.20.1