From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42234C0650F for ; Mon, 5 Aug 2019 13:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C5D52075B for ; Mon, 5 Aug 2019 13:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010504; bh=A5ZW29GuUfPYErheh8nvrd4HYtrgpzaFd7HKDsLwvE8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EG+k5gw9ehhiMRz0VXYNRzjg1gLQR2OObgOJgAmKJBGqkFgsN+WqnV6h0GWwECENO 4QWIGXj7yjjYkvcnt7oHIkksjk9AMwOI16Ow9Sp0McWFKzctLxjvjSZuR5kmRcJrC/ sFdsOOkRQALcBmmL/TbGlGPCvz0Km1ZRlxPr0qd4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730019AbfHENIW (ORCPT ); Mon, 5 Aug 2019 09:08:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:46360 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729511AbfHENIU (ORCPT ); Mon, 5 Aug 2019 09:08:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33B4E21743; Mon, 5 Aug 2019 13:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010499; bh=A5ZW29GuUfPYErheh8nvrd4HYtrgpzaFd7HKDsLwvE8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LwlQ5Fvk16CvrxlSYCgoHSrqEMp6lnMTuh5UAJTGLvZeXLwQTBvp/0Egdo0jAYvCJ wTsESNEi9+9gDbNVGGgvRMu8ea3vYUcfyFZeiUR1YVWwzh8hl5WLXWO/27qrUPALld yt43CvfDCsBcF7Z4ZhF7NOYIApm7b2DTFkwYpQ6A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yishai Hadas , Alex Vainman , Leon Romanovsky , Jason Gunthorpe Subject: [PATCH 4.14 48/53] IB/mlx5: Fix RSS Toeplitz setup to be aligned with the HW specification Date: Mon, 5 Aug 2019 15:03:13 +0200 Message-Id: <20190805124933.238863292@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190805124927.973499541@linuxfoundation.org> References: <20190805124927.973499541@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yishai Hadas commit b7165bd0d6cbb93732559be6ea8774653b204480 upstream. The specification for the Toeplitz function doesn't require to set the key explicitly to be symmetric. In case a symmetric functionality is required a symmetric key can be simply used. Wrongly forcing the algorithm to symmetric causes the wrong packet distribution and a performance degradation. Link: https://lore.kernel.org/r/20190723065733.4899-7-leon@kernel.org Cc: # 4.7 Fixes: 28d6137008b2 ("IB/mlx5: Add RSS QP support") Signed-off-by: Yishai Hadas Reviewed-by: Alex Vainman Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mlx5/qp.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -1425,7 +1425,6 @@ static int create_rss_raw_qp_tir(struct } MLX5_SET(tirc, tirc, rx_hash_fn, MLX5_RX_HASH_FN_TOEPLITZ); - MLX5_SET(tirc, tirc, rx_hash_symmetric, 1); memcpy(rss_key, ucmd.rx_hash_key, len); break; }