From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 256E0C0650F for ; Mon, 5 Aug 2019 13:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E427B21743 for ; Mon, 5 Aug 2019 13:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010510; bh=dbkT/1W9PRREMXgSxg4qoUIiFmQ3q33COSJF1tBlr4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b0ZNeJN6imAkE1uJu0QUUSEVpsj6cI+jpbikTOy8UOyihS5yhqk/gitCAJJwYRAb0 3cD7a3i1AubnZtdFr/8+GKDdmT1KvU/fyqLsb8UblQpsvV68io+fGZkg/2AjuDDCAX GT7gFZu5LCQGP2F60fFOP/CD6LulinGauO6cD8TQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730039AbfHENI2 (ORCPT ); Mon, 5 Aug 2019 09:08:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:46472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729562AbfHENIZ (ORCPT ); Mon, 5 Aug 2019 09:08:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 654CD2087B; Mon, 5 Aug 2019 13:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010504; bh=dbkT/1W9PRREMXgSxg4qoUIiFmQ3q33COSJF1tBlr4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=joCl1NIUsGgUOWKE0i1JfoocxvJZrohNxMRPKvNMstB/LnF+3oV08O0CXnB7/G2Z2 vJ1tsO076UnwbWpfWbxUCZR7oUjRMBHyLPlAI6W/qj+sQphiJwVjhtI2L07DqLPqiD ly0Egl74p0WYPBhZNN7gNx/75VK18TjSAcXKZUxI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jean Delvare , Andrew Lunn , Srinivas Kandagatla , Bartosz Golaszewski , Arnd Bergmann , Bartosz Golaszewski Subject: [PATCH 4.14 50/53] eeprom: at24: make spd world-readable again Date: Mon, 5 Aug 2019 15:03:15 +0200 Message-Id: <20190805124933.431541985@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190805124927.973499541@linuxfoundation.org> References: <20190805124927.973499541@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jean Delvare commit 25e5ef302c24a6fead369c0cfe88c073d7b97ca8 upstream. The integration of the at24 driver into the nvmem framework broke the world-readability of spd EEPROMs. Fix it. Signed-off-by: Jean Delvare Cc: stable@vger.kernel.org Fixes: 57d155506dd5 ("eeprom: at24: extend driver to plug into the NVMEM framework") Cc: Andrew Lunn Cc: Srinivas Kandagatla Cc: Greg Kroah-Hartman Cc: Bartosz Golaszewski Cc: Arnd Bergmann Signed-off-by: Bartosz Golaszewski [Bartosz: backported the patch to older branches] Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -834,7 +834,7 @@ static int at24_probe(struct i2c_client at24->nvmem_config.name = dev_name(&client->dev); at24->nvmem_config.dev = &client->dev; at24->nvmem_config.read_only = !writable; - at24->nvmem_config.root_only = true; + at24->nvmem_config.root_only = !(chip.flags & AT24_FLAG_IRUGO); at24->nvmem_config.owner = THIS_MODULE; at24->nvmem_config.compat = true; at24->nvmem_config.base_dev = &client->dev;