From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CAAAC433FF for ; Mon, 5 Aug 2019 13:13:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F7752075B for ; Mon, 5 Aug 2019 13:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010792; bh=aqKz37Eakt9EarZGFpv5j17tzyz1TZjvto7irZCRzVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ixMhVeuLdNd/TJoTG+DubQOzt9CeO9JEEUplqH2PT7THAFCtF71NJlAoizsZ+YS7l bFKnU6roSUqf2Hl67biXCJdJvOMUNwsKJD/O5KuGVmpwqOO2dr0aTdeFnzZ2fBnJsF hoOYGbR/Y4Q23u+wtg1/bzAwhmN129RJ8kjaYMzw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729916AbfHENNL (ORCPT ); Mon, 5 Aug 2019 09:13:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:48212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729823AbfHENJk (ORCPT ); Mon, 5 Aug 2019 09:09:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4CD4820880; Mon, 5 Aug 2019 13:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565010579; bh=aqKz37Eakt9EarZGFpv5j17tzyz1TZjvto7irZCRzVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FConHP3y72y99yO3kvjJbCNEE/L58/tu0vM3ycZ1jipPnaWO7Ut6ZLgIKuPgmwwEh YbAdCl6eHlNxMiW4qkE0EGXz1MEsKyhqDoJ2m4uzJNfOm3uQO7rH7sE3uLXyxr1SFI 8/3jSvvQ11uVDEe17G2dM85Wpw4CMQCK30dYdqR0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Benjamin Poirier , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 25/74] be2net: Signal that the device cannot transmit during reconfiguration Date: Mon, 5 Aug 2019 15:02:38 +0200 Message-Id: <20190805124937.794723659@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190805124935.819068648@linuxfoundation.org> References: <20190805124935.819068648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 7429c6c0d9cb086d8e79f0d2a48ae14851d2115e ] While changing the number of interrupt channels, be2net stops adapter operation (including netif_tx_disable()) but it doesn't signal that it cannot transmit. This may lead dev_watchdog() to falsely trigger during that time. Add the missing call to netif_carrier_off(), following the pattern used in many other drivers. netif_carrier_on() is already taken care of in be_open(). Signed-off-by: Benjamin Poirier Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/emulex/benet/be_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index bff74752cef16..3fe6a28027fe1 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -4700,8 +4700,12 @@ int be_update_queues(struct be_adapter *adapter) struct net_device *netdev = adapter->netdev; int status; - if (netif_running(netdev)) + if (netif_running(netdev)) { + /* device cannot transmit now, avoid dev_watchdog timeouts */ + netif_carrier_off(netdev); + be_close(netdev); + } be_cancel_worker(adapter); -- 2.20.1