From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B4AC0650F for ; Mon, 5 Aug 2019 13:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A3F62067D for ; Mon, 5 Aug 2019 13:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565011456; bh=but4/aoqQhAlVg1ekjeuY57oNWH9FIgLys4thN8s+3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=V50TC/jCIRTss10pO5PWf3wfBLQspisg8LTnnUAAEx3EjLiLWgvdVdpeKN9Y9s72q hQM/xBLd+dl/HIYclCCmZgZgs9kUHPeFGV/TM973AJw26oZKjEuosP2YHz+5MRnIT0 nymNt4meU8qjDbvEngqhLFhsbVMI4Wr946Ih87b8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730972AbfHENYO (ORCPT ); Mon, 5 Aug 2019 09:24:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:60932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730966AbfHENYK (ORCPT ); Mon, 5 Aug 2019 09:24:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE6552067D; Mon, 5 Aug 2019 13:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565011450; bh=but4/aoqQhAlVg1ekjeuY57oNWH9FIgLys4thN8s+3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xX3aoLKqronXYjk9Q/tF3vHOtuoZU6zLbctkDoaCtguH294qcapWTqR/Svcc6Xl+j 0uGAR+dLBj16YNCN1s0qSCDaj0NApWMBTX2nR03eUoPNGhnNXHIwD7i11pNOEJQo83 886d6u+ewS+m7//F73ABSWDD2EdtxmME1t9Km91Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "M. Vefa Bicakci" , Masahiro Yamada Subject: [PATCH 5.2 075/131] kconfig: Clear "written" flag to avoid data loss Date: Mon, 5 Aug 2019 15:02:42 +0200 Message-Id: <20190805124956.731138588@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190805124951.453337465@linuxfoundation.org> References: <20190805124951.453337465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: M. Vefa Bicakci commit 0c5b6c28ed68becb692b43eae5e44d5aa7e160ce upstream. Prior to this commit, starting nconfig, xconfig or gconfig, and saving the .config file more than once caused data loss, where a .config file that contained only comments would be written to disk starting from the second save operation. This bug manifests itself because the SYMBOL_WRITTEN flag is never cleared after the first call to conf_write, and subsequent calls to conf_write then skip all of the configuration symbols due to the SYMBOL_WRITTEN flag being set. This commit resolves this issue by clearing the SYMBOL_WRITTEN flag from all symbols before conf_write returns. Fixes: 8e2442a5f86e ("kconfig: fix missing choice values in auto.conf") Cc: linux-stable # 4.19+ Signed-off-by: M. Vefa Bicakci Signed-off-by: Masahiro Yamada Signed-off-by: Greg Kroah-Hartman --- scripts/kconfig/confdata.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -867,6 +867,7 @@ int conf_write(const char *name) const char *str; char tmpname[PATH_MAX + 1], oldname[PATH_MAX + 1]; char *env; + int i; bool need_newline = false; if (!name) @@ -949,6 +950,9 @@ next: } fclose(out); + for_all_symbols(i, sym) + sym->flags &= ~SYMBOL_WRITTEN; + if (*tmpname) { if (is_same(name, tmpname)) { conf_message("No change to %s", name);