From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Keith Busch <keith.busch@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Frederick Lawler <fred@fredlawl.com>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Sinan Kaya <okaya@kernel.org>,
Kai Heng Feng <kai.heng.feng@canonical.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: pciehp: Do not disable interrupt twice on suspend
Date: Mon, 5 Aug 2019 16:13:06 +0300 [thread overview]
Message-ID: <20190805131306.GQ2640@lahna.fi.intel.com> (raw)
In-Reply-To: <20190804195306.gm4livsxkrleaciv@wunner.de>
On Sun, Aug 04, 2019 at 09:53:06PM +0200, Lukas Wunner wrote:
> On Tue, Jun 18, 2019 at 03:50:50PM +0300, Mika Westerberg wrote:
> > @@ -313,10 +332,12 @@ static struct pcie_port_service_driver hpdriver_portdrv = {
> > .remove = pciehp_remove,
> >
> > #ifdef CONFIG_PM
> > +#ifdef CONFIG_PM_SLEEP
> > .suspend = pciehp_suspend,
> > .resume_noirq = pciehp_resume_noirq,
> > +#endif
> > .resume = pciehp_resume,
> > - .runtime_suspend = pciehp_suspend,
> > + .runtime_suspend = pciehp_runtime_suspend,
> > .runtime_resume = pciehp_runtime_resume,
> > #endif /* PM */
> > };
>
> Hm, why isn't ".resume" part of the "#ifdef CONFIG_PM_SLEEP" section?
Good point. I'll move it there.
prev parent reply other threads:[~2019-08-05 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 12:50 [PATCH 1/2] PCI: pciehp: Do not disable interrupt twice on suspend Mika Westerberg
2019-06-18 12:50 ` [PATCH 2/2] PCI: pciehp: Prevent deadlock on disconnect Mika Westerberg
2019-08-05 11:18 ` Lukas Wunner
2019-08-05 12:59 ` Mika Westerberg
2019-06-21 8:52 ` [PATCH 1/2] PCI: pciehp: Do not disable interrupt twice on suspend Kai-Heng Feng
2019-06-24 9:34 ` Rafael J. Wysocki
2019-08-04 19:53 ` Lukas Wunner
2019-08-05 13:13 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805131306.GQ2640@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=fred@fredlawl.com \
--cc=gustavo@embeddedor.com \
--cc=kai.heng.feng@canonical.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=okaya@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).