linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: pi433 line over 80 characters in multiple places
@ 2019-08-05  0:02 Giridhar Prasath R
  2019-08-05 14:36 ` Dan Carpenter
  2019-08-05 15:03 ` Greg Kroah-Hartman
  0 siblings, 2 replies; 3+ messages in thread
From: Giridhar Prasath R @ 2019-08-05  0:02 UTC (permalink / raw)
  Cc: Giridhar Prasath R, Greg Kroah-Hartman, Michael Straube, devel,
	linux-kernel

Fix the following checkpatch warnings:

WARNING: line over 80 characters
FILE: drivers/staging/pi433/pi433_if.h

Signed-off-by: Giridhar Prasath R <cristianoprasath@gmail.com>
---
 drivers/staging/pi433/pi433_if.h | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index 9feb95c431cb..915bd96910c6 100644
--- a/drivers/staging/pi433/pi433_if.h
+++ b/drivers/staging/pi433/pi433_if.h
@@ -117,9 +117,14 @@ struct pi433_rx_cfg {
 
 	/* packet format */
 	enum option_on_off	enable_sync;
-	enum option_on_off	enable_length_byte;	  /* should be used in combination with sync, only */
-	enum address_filtering	enable_address_filtering; /* operational with sync, only */
-	enum option_on_off	enable_crc;		  /* only operational, if sync on and fixed length or length byte is used */
+	/* should be used in combination with sync, only */
+	enum option_on_off	enable_length_byte;
+	/* operational with sync, only */
+	enum address_filtering	enable_address_filtering;
+	/* only operational,
+	 * if sync on and fixed length or length byte is used
+	 */
+	enum option_on_off	enable_crc;
 
 	__u8			sync_length;
 	__u8			fixed_message_length;
@@ -132,10 +137,14 @@ struct pi433_rx_cfg {
 
 #define PI433_IOC_MAGIC			'r'
 
-#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
-#define PI433_IOC_WR_TX_CFG	_IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
+#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
+char[sizeof(struct pi433_tx_cfg)])
+#define PI433_IOC_WR_TX_CFG	_IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
+char[sizeof(struct pi433_tx_cfg)])
 
-#define PI433_IOC_RD_RX_CFG	_IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)])
-#define PI433_IOC_WR_RX_CFG	_IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)])
+#define PI433_IOC_RD_RX_CFG	_IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\
+char[sizeof(struct pi433_rx_cfg)])
+#define PI433_IOC_WR_RX_CFG	_IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\
+char[sizeof(struct pi433_rx_cfg)])
 
 #endif /* PI433_H */
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: pi433 line over 80 characters in multiple places
  2019-08-05  0:02 [PATCH] staging: pi433 line over 80 characters in multiple places Giridhar Prasath R
@ 2019-08-05 14:36 ` Dan Carpenter
  2019-08-05 15:03 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2019-08-05 14:36 UTC (permalink / raw)
  To: Giridhar Prasath R; +Cc: Greg Kroah-Hartman, devel, linux-kernel

The subject needs a colon after "pi433:" but also this change isn't
really an improvement so far as readability goes.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: pi433 line over 80 characters in multiple places
  2019-08-05  0:02 [PATCH] staging: pi433 line over 80 characters in multiple places Giridhar Prasath R
  2019-08-05 14:36 ` Dan Carpenter
@ 2019-08-05 15:03 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-08-05 15:03 UTC (permalink / raw)
  To: Giridhar Prasath R; +Cc: devel, linux-kernel

On Mon, Aug 05, 2019 at 05:32:45AM +0530, Giridhar Prasath R wrote:
> Fix the following checkpatch warnings:
> 
> WARNING: line over 80 characters
> FILE: drivers/staging/pi433/pi433_if.h
> 
> Signed-off-by: Giridhar Prasath R <cristianoprasath@gmail.com>
> ---
>  drivers/staging/pi433/pi433_if.h | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index 9feb95c431cb..915bd96910c6 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -117,9 +117,14 @@ struct pi433_rx_cfg {
>  
>  	/* packet format */
>  	enum option_on_off	enable_sync;
> -	enum option_on_off	enable_length_byte;	  /* should be used in combination with sync, only */
> -	enum address_filtering	enable_address_filtering; /* operational with sync, only */
> -	enum option_on_off	enable_crc;		  /* only operational, if sync on and fixed length or length byte is used */
> +	/* should be used in combination with sync, only */
> +	enum option_on_off	enable_length_byte;
> +	/* operational with sync, only */
> +	enum address_filtering	enable_address_filtering;
> +	/* only operational,
> +	 * if sync on and fixed length or length byte is used
> +	 */
> +	enum option_on_off	enable_crc;
>  
>  	__u8			sync_length;
>  	__u8			fixed_message_length;
> @@ -132,10 +137,14 @@ struct pi433_rx_cfg {
>  
>  #define PI433_IOC_MAGIC			'r'
>  
> -#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> -#define PI433_IOC_WR_TX_CFG	_IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> +#define PI433_IOC_RD_TX_CFG	_IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
> +char[sizeof(struct pi433_tx_cfg)])

Ick, that does not look better :(

We write code for humans first, compilers second.

The original is fine, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-05 15:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05  0:02 [PATCH] staging: pi433 line over 80 characters in multiple places Giridhar Prasath R
2019-08-05 14:36 ` Dan Carpenter
2019-08-05 15:03 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).